Feeling Lucky
?
?
[#20976] - [4.0] Admin menu empty target
- Fixed in Code Base
- 11 Jul 2018
- Medium
- Build: 4.0-dev
- # 20976
- Diff
- SharkyKZ:menuTarget
User tests: Successful: Unsuccessful:
Pull Request for Issue #20975.
Summary of Changes
This prevents target attribute with empty value being added to links in administrator menu module.
Testing Instructions
Inspect HTML markup generated by administrator menu module.
Expected result
Empty target attribute not added, e.g. <li role="menuitem"><a class="no-dropdown" href="index.php"><span class="sidebar-item-title">Control Panel</span></a></li>
Actual result
Empty target attribute added, e.g. <li role="menuitem"><a class="no-dropdown" href="index.php" target=""><span class="sidebar-item-title">Control Panel</span></a></li>
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Labels |
Added:
?
|
||
Quy
- comment
- 8 Jul 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20976.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 8 Jul 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20976.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-11 07:33:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 29a2686
Works, no more empty target="" (no more invalid HTML)
Also about target="0" , 0 is an valid frame name , the fact that frames are deprecated in HTML5, is not reason to handle target="0" differently than target="1"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20976.