User tests: Successful: Unsuccessful:
The JS in com_finder in 4.0 is very broken. There are several issues:
This PR fixes all of these things. I first updated the awesomplete suggestion script with the current head version from its repo (https://github.com/LeaVerou/awesomplete). The last release is from 2017 and we already have that in our codebase, which currently creates the focus errors.
I then created the awesomplete object just once and attached it to the input object, instead of creating it on each ajax call. Now we just update the list instead.
The event for the suggestions update is now upon "keyup", which then now takes the right string for the suggestions.
There is a bit of code that seems to be from a time where the placeholder attribute wasn't present. I removed that.
And last but not least, the error case for the ajax call first checks if there is any status code given. When we are just aborting the ajax call because we are submitting the form, then the status code is 0, otherwise it would be something like 200, 404 or 500.
Happy testing. Hope this makes you happy, @infograf768 and @carlitorweb
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript |
Labels |
Added:
?
|
package.json supports github repo links, which is what I did. I also did not modify the awesomplete files, but simply took the current head of their github repo. Considering that the last commit that I did to this PR is the result of npm install
, I'm pretty confident with this. BTW: When doing an npm install
on the current head of 4.0-dev, there is quite a few things that are being changed. So maybe you should again update this.
Focus back and suggestions look fine with my first tests.
Now, just please solve the highlighting for non-ascii stuff. ;)
I have tested this item
nice one!!!
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-01 13:52:06 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
@Hackwar if you need to do changes on a vendor file you need to do them upstream!
This cannot be accepted because the
npm install
is removing the media/vendor folder and recreates it from the relative sources. So this is a no go!Also the package.json dependencies have a format
npm name
:version
so putting there some string is not gonna work.Just do a
npm i
ornode build.js --update
and see what you are breaking here