[#20718] - [4.0] HTML class naming standard [frontend modules]
- Fixed in Code Base
- 13 Jun 2018
- Medium
- Build: 4.0-dev
- # 20718
- Diff
- ciar4n:class-naming-mod1
- Pending Hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #15279 .
Summary of Changes
Adds HTML classes using the following standard to all frontend modules.
Default views
ExtensionType-Extension (Eg. mod-articlesnews).
Alternative layout views
ExtensionType-Extension-View (Eg. mod-articlesnews-vertical).
Child views and child elements within the views
BEM class naming is adopted..
- Block (https://en.bem.info/methodology/quick-start/#block):
ExtensionType-Extension(-View) - Element (https://en.bem.info/methodology/quick-start/#element): Child view/element
ExtensionType-Extension__Element (Eg. https://github.com/joomla/joomla-cms/blob/4.0-dev/modules/mod_menu/tmpl/default_heading.php - mod-menu__heading).
For B/C, old classes remain. This PR is a continuation of this standard already applied to mod-login ( #20147).
Testing Instructions
Code review.
Expected result
All works fine
Actual result
All works fine
Documentation Changes Required
Yes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
?
|
||
@richard67 Only with mod-menu. As you have a PR already open regarding this area, I decided to leave it out here.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-13 11:55:20 |
| Closed_By | ⇒ | wilsonge |
Merged mod_menu first then this one - so should all be good! thanks guys :)
Doesn’t this also require an update of (s)css e.e. of the Cassiopeia template?