Joomla! Issue Tracker | Joomla! CMS #20719

Closed
11 Jun 2018
Medium
Build: staging
# 20719

brianteeman
11 Jun 2018

Steps to reproduce the issue

Spotted this testing a plugin. As can be seen in the screenshot the alert title is lowercase and it should be capitalised. I "suspect" that it is also not translatable

brianteeman - open - 11 Jun 2018

joomla-cms-bot - change - 11 Jun 2018

Labels

Added: ?

joomla-cms-bot - labeled - 11 Jun 2018

dgrammatiko - comment - 11 Jun 2018

it's not the custom element: https://github.com/joomla/joomla-cms/blob/4.0-dev/media/vendor/joomla-custom-elements/js/joomla-alert.js
it's the core.js:

joomla-cms/media/system/js/core.js

Lines 413 to 420 in 8d048ad

    
           // Message class 
        
           if (['notice','message', 'error'].indexOf(type) > -1) { 
        
           	alertClass = (type === 'notice') ? 'info' : type; 
        
           	alertClass = (type === 'message') ? 'success' : alertClass; 
        
           	alertClass = (type === 'error') ? 'danger' : alertClass; 
        
           } else { 
        
           	alertClass = 'info'; 
        
           }

(type is lowercase in J4)

But it is still translatable: https://github.com/joomla/joomla-cms/blob/4.0-dev/media/system/js/core.js#L434

brianteeman - change - 11 Jun 2018

Title

…

[4.0] Alerts - ~~custom element~~

[4.0] Alerts -

brianteeman - edited - 11 Jun 2018

brianteeman - comment - 11 Jun 2018

That explains why my tests on changing the element didnt work ;)

It is only translatable though if we give translators strings to translate which if I read the js code correctly we are not

dgrammatiko - comment - 11 Jun 2018

If you want to do the change the hardcoded part is here:

joomla-cms/layouts/joomla/system/message.php

Lines 17 to 27 in 8d048ad

    
           $alert = [ 
        
           	CMSApplication::MSG_EMERGENCY => 'danger', 
        
           	CMSApplication::MSG_ALERT     => 'danger', 
        
           	CMSApplication::MSG_CRITICAL  => 'danger', 
        
           	CMSApplication::MSG_ERROR     => 'danger', 
        
           	CMSApplication::MSG_WARNING   => 'warning', 
        
           	CMSApplication::MSG_NOTICE    => 'info', 
        
           	CMSApplication::MSG_INFO      => 'info', 
        
           	CMSApplication::MSG_DEBUG     => 'info', 
        
           	'message'                     => 'success' 
        
           ];

But if, lets say, type info is πληροφορία in greek, then we need to make sure the custom element is checking also against that string. If you patch the php part I'll make sure the js (ce and core) are also patched.

ggppdk - comment - 11 Jun 2018

So the translating method is already called inside the JS code

And also the language strings exist
in frontend and backend language files
https://github.com/joomla/joomla-cms/blob/4.0-dev/language/en-GB/en-GB.ini#L12-L18
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/language/en-GB/en-GB.ini#L41-L47

JHtmlBehavior::core()
libraries/cms/html/behavior.php

needs to load them

ggppdk - comment - 11 Jun 2018

I have made a PR #20721

joomla-cms-bot - change - 11 Jun 2018

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2018-06-11 18:07:13
Closed_By		⇒	joomla-cms-bot

joomla-cms-bot - close - 11 Jun 2018

Quy - change - 11 Jun 2018

Closed_Date	2018-06-11 18:07:13	⇒	2018-06-11 18:07:14
Closed_By	joomla-cms-bot	⇒	Quy

joomla-cms-bot - comment - 11 Jun 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20719

brianteeman - comment - 11 Jun 2018

@ggppdk your code doesnt work

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#20719] - [4.0] Alerts -

Steps to reproduce the issue

Add a Comment

	// Message class
	if (['notice','message', 'error'].indexOf(type) > -1) {
	alertClass = (type === 'notice') ? 'info' : type;
	alertClass = (type === 'message') ? 'success' : alertClass;
	alertClass = (type === 'error') ? 'danger' : alertClass;
	} else {
	alertClass = 'info';
	}

	$alert = [
	CMSApplication::MSG_EMERGENCY => 'danger',
	CMSApplication::MSG_ALERT => 'danger',
	CMSApplication::MSG_CRITICAL => 'danger',
	CMSApplication::MSG_ERROR => 'danger',
	CMSApplication::MSG_WARNING => 'warning',
	CMSApplication::MSG_NOTICE => 'info',
	CMSApplication::MSG_INFO => 'info',
	CMSApplication::MSG_DEBUG => 'info',
	'message' => 'success'
	];