[#20717] - [Newsfeeds] Use item link instead of guid.
- Fixed in Code Base
- 12 Jun 2018
- Medium
- Build: staging
- # 20717
- Diff
- SharkyKZ:RSS_Permalink
User tests: Successful: Unsuccessful:
Pull Request for Issue #19919.
Summary of Changes
This changes newsfeed links in com_newsfeeds to use URL from item's <link> element as opposed to <guid> element. This is already done in mod_feed. Additionally, this adds a check for GUID's isPermaLink property so <guid> can only be used when <link> is missing and isPermaLink is not set to false.
Testing Instructions
Install Joomla with sample data. Check newsfeed links in com_newsfeeds.
Expected result
Links like this: http://feeds.joomla.org/~r/JoomlaAnnouncements/~3/w60t6iTw8NI/5730-joomla-3-8-8-release.html
Actual result
Links like this: https://www.joomla.org/announcements/release-news/5730-joomla-3-8-8-release.html
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Front End com_newsfeeds Libraries |
| Labels |
Added:
?
|
||
@sozzled Please do the following to mark your test result:
- Open Issue Tracker
- Log in with your Github account
- Click on blue
Test thisbutton above author's photo - Select
Tested successfully - Click
Submit test result
I have tested this item
Big improvement!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
Thanks, @Quy. This is a big improvement.
The changes do not fix the problem I noted w.r.t. the Australian Federal Police news feed but that's also because the AFP news feed does not PROPERLY conform to the RSS feed specification (because the date/time does not use the correct format): see https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.afp.gov.au%2Ffeed%2Fmedia-releases
This results in Joomla producing "out-of-date" bookmark/404 error page with the message
DateTime::__construct(): Failed to parse time string (Monday, June 11, 2018 - 06:41) at position 22 (-): Unexpected character>
which is probably to be expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
As far as I'm concerned, these changes are good to go.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
Just tried it. I did not find any problem with already working newsfeeds.
Pascal
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
Tests with recent changes all satisfactory. I found the cause of the problem with the Australian Federal Police newsfeed: the problem is with the source of the feed (the date/time information is not in the correct format). This is not a problem as far as I am concerned and Joomla cannot be blamed for not being able to compensate for a fault in the RSS feed data (i.e. the XML file) that causes the error message (a 404 page):
DateTime::__construct(): Failed to parse time string (Monday, June 11, 2018 - 06:41) at position 22 (-): Unexpected character
See the News Feed Validator results for this particular news feed here: https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.afp.gov.au%2Ffeed%2Fmedia-releases
(I may report the problem with the AFP newsfeed to the webmaster at the AFP website :D )
All good as far as I'm concerned.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
See http://joomla37.enduring.com.au/index.php/news-feed-tests for the tests I used.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-12 22:40:57 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20717.
@Pierantonio thanks for testing this Pull Request (PR). But testing a merged one isn't necessary.
It would help if you test PR with no or only one Test. To find them: on Tracker open "Search Tools" > "Tests":
Wow! This is a big improvement!
I've tested the changes against the range of tests that I referred to in #19919 and I can confirm that
(a) all the previous newsfeeds that worked before J! 3.8.8 continue to work; and
(b) two of the three newsfeeds that did not work before J! 3.8.8. now work.
I might investigate why the newsfeed from the Australian Federal Police does not work (this was "Test No. 4 I referred to in #19919): https://www.afp.gov.au/feed/media-releases ... but this is not a significant worry for me; the AFP newsfeed was just something I chose to test.