Feeling Lucky
?
?
[#20412] - [plg_user_profile] Misc fixes
- Fixed in Code Base
- 23 May 2018
- Medium
- Build: staging
- # 20412
- Diff
- SharkyKZ:plg_user_profile_1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Added filters and default values to manifest file.
Added filter to ToS field to prevent invalid data from being saved.
Removed &lang=* from ToS article URL.
Replaced tooltip with popover for ToS field, to be consistent with other fields.
Some CS (camelCase).
Testing Instructions
- Code review. Check that added default values match fallback values in plugin code.
- Select a ToS article. Check the URL of the article in registration form.
- When registering, use developer tools in browser to modify ToS input value, e.g.:
<input id="jform_profile_tos0" name="jform[profile][tos]" value="foobar" required="" aria-required="true" type="radio">
Expected result
https://example.com/article-url?tmpl=component- Registration fails because ToS not accepted.
Actual result
https://example.com/article-url?tmpl=component&lang=*- Registration successful,
"foobar"written to#__user_profilestable as ToS value.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Quy
- comment
- 16 May 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20412.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 16 May 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20412.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-23 23:59:51 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on bc85b9c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20412.