[#20413] - Fixing com_fields integration in com_contact
- Fixed in Code Base
- 18 Jun 2018
- Medium
- Build: staging
- # 20413
- Diff
- artur-stepien:patch-9
User tests: Successful: Unsuccessful:
Custom fields in com_contact currently doesn't work propertly. Choosing a category on which they should appear doesn't work cause fields plugin has no information about contact catid as not data is passed to form when contact form is displayed. Below is a test for the bug it fixes.
Summary of Changes
Adding catid to contact form data.
Testing Instructions
- Create 2 contacts categories
- Create 2 contacts, select them different categories and link them in menu (with enabled contact form)
- Create 2 checkbox type fields (in
Mailgroup so they will be displayed in contact form), One should have a selected category, the other should haveAllin category select - Go to front and look at both contact forms
Expected result
- One contact should have 2 checkbox fields added
- The other should have only one checkbox field added
Actual result
- Both checkboxes display in both contacts
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End com_contact |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-17 03:38:31 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2018-05-17 03:38:31 | ⇒ | 2018-05-17 03:38:32 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20413
If @artur-stepien finds a better way, then we are open for a new solution. For now this fixed the bug.
@artur-stepien comment about #20214 IS the better way. Data validation is a model responsibility, not the view. Unless you're Joomla and only explicitly supporting HTML views.
| Status | Closed | ⇒ | New |
| Closed_Date | 2018-05-17 03:38:32 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ |
| Status | New | ⇒ | Pending |
Set to "open" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/20413
Reopening
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20413.
I have tested this item
Reverted #20214 and removed the code #20214 deleted.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20413.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20413.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
The author of the pr should not test its own pr. Anyway the code in the view fixed a couple of different issues. We should make sure that we test all of them too.
| Status | Ready to Commit | ⇒ | Pending |
Yeah, but as you can see no one cares about checking something that takes few minutes. And this issue is blocking changes required for GDPR. Not to mention that I wouldn't create PR for something that doesn't work. Testing that wouldn't take much longer then writing those comments ...
I don't know which lines to delete before testing this pr.
Does this pr replace red AND green lines in https://github.com/joomla/joomla-cms/pull/20214/files ?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20413.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-18 02:56:45 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Fixed in #20214 that will be in v3.8.8.