[#20411] - [com_finder] Fix toggle selection (Regression #19969)
- Fixed in Code Base
- 18 May 2018
- Medium
- Build: staging
- # 20411
- Diff
- Quy:patch-4
User tests: Successful: Unsuccessful:
Fix regression for Issue #19969.
Summary of Changes
PR #19969 attempts to fix #19930, however, broke the Toggle Selection functionality. This PR removes the for attribute which is not required since the checkbox is wrapped in the label tag and use the id for the Toggle Selection button.
Testing Instructions
Go to Components > Smart Search
Click Index button
Click Search Filters
Click New button
Go to a section and click the Toggle Selection button
Expected result
Toggle Selection button toggles the checkboxes.
Actual result
Toggle Selection button does not toggle the checkboxes.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_finder |
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20411.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Thanks for Tests, guys
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-18 11:12:36 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 107b943
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20411.