? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
15 May 2018

Pull Request for Issue # .

Summary of Changes

This adds filter attribute to some fields in plugin manifest files.

Testing Instructions

Code review:

  1. Check that filtered default value is identical (including data type) to fallback value inside plugin code.
  2. Check that comparisons are valid (not type safe or, if type safe, not compared to different type).

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 15 May 2018
avatar SharkyKZ SharkyKZ - change - 15 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2018
Category Front End Plugins
avatar SharkyKZ SharkyKZ - change - 15 May 2018
The description was changed
avatar SharkyKZ SharkyKZ - edited - 15 May 2018
avatar Quy Quy - test_item - 15 May 2018 - Tested successfully
avatar Quy
Quy - comment - 15 May 2018

I have tested this item successfully on 042cfa5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20410.

avatar carlitorweb carlitorweb - test_item - 15 May 2018 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 15 May 2018

I have tested this item successfully on 042cfa5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20410.

avatar Quy Quy - change - 15 May 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 15 May 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20410.

avatar wilsonge wilsonge - change - 15 May 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-15 21:03:04
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 15 May 2018
avatar wilsonge wilsonge - merge - 15 May 2018
avatar wilsonge
wilsonge - comment - 15 May 2018

Awesome stuff! Thanks!

Add a Comment

Login with GitHub to post a comment