[#20329] - [3.10] Make sure the update hash checker produces the correct result
- Closed
- 1 Jun 2018
- Medium
- Build: 3.9-dev
- # 20329
- Diff
- zero-24:fix39updater
User tests: Successful: Unsuccessful:
Summary of Changes
- Only show a message when the verification fails (request by @mbabker )
- Handle the verification locally in com_joomlaupdate so we don't depend on the other method to be up-to-date. (like releasing a standalone version)
- Throw something in the log when the verification fails.
- Make sure we are using the correct update object and don't do some magic with passing the update xml.
Testing Instructions
First Case
- install 3.9-dev https://developer.joomla.org/nightlies/Joomla_3.9.0-dev-Development-Full_Package.zip
- Apply this update server: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
- install the update
- notice there is a warning claiming that the hash was not set. ;)
Seccond Case
- Install 3.9-dev with this changes: https://github.com/zero-24/joomla-cms/archive/fix39updater.zip
- Apply this update server: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
- install the update
- notice there is no warning
Expected result
Make sure the update works without any kind of warning
Actual result
Well the update works but throws a warning as the url is not passed.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
Handle the verification locally in com_joomlaupdate so we don't depend on the other method to be up-to-date. (like releasing a standalone version)
Don't understand (but it's me ;) ) , can you give me a pratical example?
We are able to release an update of com_joomlaupdate standalone from Joomla core in case there are cases where the update component needs to be updated before running a core update (this has happened before). So, the update component can't rely 100% on the core Installer or Updater libraries, especially as new features (such as this) are introduced, inlining (duplicating) this code within the component ensures if we do have a situation in the future where a standalone package has to be built that if it's applied to a Joomla version where this feature (or a similar case for future feature additions) doesn't exist it doesn't cause fatal errors.
make sense thanks for the explanation
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20329.
Install 3.9-dev with this changes: https://github.com/zero-24/joomla-cms/archive/fix39updater.zip
When I install this package com_joomlaupdate says "You already have the latest Joomla version, 3.10.0-dev". Shouldn't it be 3.9-dev for testing?
Or is this pr already RTC?
| Title |
|
||||||
(updated title to show it is now for 3.10)
It's actually intended for 3.9 but because of the branch changes it had to be moved to the 3.10-dev branch otherwise the PR would've been totally broken. Test this as is, when RTC the same patch will apply to the 3.9-dev branch.
Test this as is
Maybe i don't understand correctly. Step "Second Case" of testing instructions is not testable for me as is because https://github.com/zero-24/joomla-cms/archive/fix39updater.zip installs a Joomla 3.10 (instead of expected 3.9). Afterwards com_joomlaupdate with update server https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml doesn't offer the possibility to reinstall an update package because only 3.9 versions are included in xml file.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-01 18:10:15 |
| Closed_By | ⇒ | zero-24 |
Tagging @alikon too ;)