Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#20330] - [3.10] Make sure the extension install works as expected

? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
9 May 2018

Summary of Changes

Only show a message when the verification fails (request by @mbabker )
Remove the check at install time.
Make sure we are using the correct update object and don't do some magic with passing the update xml.

Testing Instructions

  • Install 3.9-dev https://developer.joomla.org/nightlies/Joomla_3.9.0-dev-Development-Full_Package.zip
  • Install any outdated extension that do not support hashes yet (well all 3rd party tools)
  • notice the message saying that there is no hash provided
  • install the update
  • notice the message saying that there is no hash provided
  • apply this patch
  • redo the steps above
  • notice that there is no message at all.
  • install com_patchtester
  • notice there is no message
  • apply the update to the latest com_patchtester
  • notice there is no message at all. (even as they use hashes)

Expected result

Only show a message when the verification fails (request by @mbabker )
Remove the check at install time.
Make sure we are using the correct update object and don't do some magic with passing the update xml.

Documentation Changes Required

None.

avatar zero-24 zero-24 - open - 9 May 2018
avatar zero-24 zero-24 - change - 9 May 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2018
Category ⇒ Administration com_installer Language & Strings Libraries
avatar zero-24 zero-24 - change - 9 May 2018
The description was changed
avatar zero-24 zero-24 - edited - 9 May 2018
avatar zero-24
zero-24 - comment - 9 May 2018

Tagging @alikon too ;)

avatar zero-24 zero-24 - change - 9 May 2018
Labels Added: ? ?
avatar alikon
alikon - comment - 11 May 2018

Why remove the check at install time ?

avatar infograf768
infograf768 - comment - 11 May 2018

Languages install/reinstall/uninstall fine with this patch.

avatar zero-24 zero-24 - change - 17 May 2018
Labels Added: ?
Removed: ?
avatar alikon
alikon - comment - 27 May 2018

I have tested this item ✅ successfully on a6059d5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20330.

avatar alikon alikon - test_item - 27 May 2018 - Tested successfully
avatar brianteeman brianteeman - change - 31 May 2018
Title
…
[3.9] Make sure the extension install works as expected
[3.10] Make sure the extension install works as expected
avatar brianteeman brianteeman - edited - 31 May 2018
avatar brianteeman
brianteeman - comment - 31 May 2018

(updated title to show it is now for 3.10)

avatar zero-24 zero-24 - change - 1 Jun 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-06-01 18:18:26
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 1 Jun 2018
avatar zero-24
zero-24 - comment - 1 Jun 2018

Moved: #20646

Add a Comment

Login with GitHub to post a comment