? ? Pending

User tests: Successful: Unsuccessful:

avatar htmgarcia
htmgarcia
9 May 2018

Pull Request for Issue # .

Summary of Changes

Replace "label" classes (not available in Bootstrap 4) with the new "badge" ones in frontend and backend

Testing Instructions

You can test in several places.
As example. Preview single articles that include tags in frontend

Expected result

The tags should have styling (color, background, etc) (with "badge" classes)

Actual result

The tags looks like regular links (with "label" classes)

Documentation Changes Required

Replacing the "label" classes with "badge" ones. That summarize this PR.

avatar htmgarcia htmgarcia - open - 9 May 2018
avatar htmgarcia htmgarcia - change - 9 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2018
Category Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Libraries Modules Plugins
avatar Quy Quy - change - 9 May 2018
Title
Replace "label" classes with the new "badge" ones
[4.0] Replace "label" classes with the new "badge" ones
avatar joomla-cms-bot joomla-cms-bot - edited - 9 May 2018
avatar brianteeman
brianteeman - comment - 9 May 2018

Can you please check in this repo where the admin template etc is being developed as I believe this has already been done https://github.com/joomla/40-backend-template/

avatar htmgarcia
htmgarcia - comment - 10 May 2018

@brianteeman I didn't included any change related to the backend template.

avatar htmgarcia htmgarcia - change - 10 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 10 May 2018
Category Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Libraries Modules Plugins Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins
avatar Quy
Quy - comment - 10 May 2018

I have tested this item successfully on b8c7f7f

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20328.

avatar Quy Quy - test_item - 10 May 2018 - Tested successfully
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2018
Category Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins Unit Tests Repository Administration com_admin SQL
avatar htmgarcia htmgarcia - change - 11 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2018
Category Administration Unit Tests Repository com_admin SQL Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins
avatar htmgarcia htmgarcia - change - 11 May 2018
Labels Removed: ?
avatar htmgarcia
htmgarcia - comment - 11 May 2018

Resolved conflicts.

avatar htmgarcia
htmgarcia - comment - 14 May 2018

@rdeutz everything looks fine to me. May you review this PR, please?

avatar dgrammatiko
dgrammatiko - comment - 14 May 2018

@ciar4n and @wilsonge do you really want to tightly couple the front end to Bootstrap? There is always the option to extend to some random unique class which will work nicely with but especially without Bootstrap (you can even keep the old classes and extend them to badge).

Personally I wouldn't tightly couple the FRONTEND core output to Bootstrap, it brings more limitations than the promised easiness of doing things. Also it's a no go if someone needs to build a fairly performant site, whatever that means according to the current benchmarking tools out there (google is probably installed in every client pc, so lighthouse is just a click away). Food for thought...

avatar mbabker
mbabker - comment - 14 May 2018

The badge/label utility class isn't going to "tightly couple the FRONTEND core output to Bootstrap".

Pick a standard, stick with it, or say "screw every existing standard" and write the Joomla CSS Framework already.

avatar brianteeman
brianteeman - comment - 14 May 2018

@htmgarcia it can't be merged until it passes all the tests

avatar htmgarcia
htmgarcia - comment - 14 May 2018

@brianteeman This PR is just about replacing "label" as classname in the HTML. Nothing fancy.
Sorry. I don't follow the 2 fails on the checks. Any idea what's the issue with these failed checks?

avatar ciar4n
ciar4n - comment - 15 May 2018

At this stage it is safe to say we are not going to be creating our own CSS framework. Prefixing one of the current standards (eg Bootstrap) is the only viable option IF we want to decouple the views from Bootstrap. To do that we either

  1. Rewrite an existing framework manually, taking what we need and prefixing all the classes (#15225)
  2. Automating the prefixing at a SCSS compiler level.

I've looked in to the second option (the ideal of the 2) however the automated prefixing modules I've tested to date do not play nice with SCSS @extends which pretty much rules out using Bootstrap. Most other frameworks avoid @extend (https://csswizardry.com/2016/02/mixins-better-for-performance/).

avatar htmgarcia
htmgarcia - comment - 16 May 2018

@brianteeman @wilsonge may we merge this one, pretty please?

avatar brianteeman
brianteeman - comment - 16 May 2018

@htmgarcia it can't be merged until it passes all the tests

it still has zero user tests

avatar htmgarcia
htmgarcia - comment - 16 May 2018
avatar brianteeman
brianteeman - comment - 16 May 2018

tests are reset when the code changes which you did when you resolved the conflicts

avatar Quy
Quy - comment - 18 May 2018

Found some more. Please see screenshot.

badge

avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2018
Category Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout JavaScript Modules Plugins
avatar Quy
Quy - comment - 21 May 2018

There are 3 more in the screenshot that have to be replaced.

avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2018
Category Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins JavaScript Administration com_banners com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout JavaScript Modules Plugins
avatar Quy
Quy - comment - 21 May 2018

Sorry these should be the last ones.

COM_JOOMLAUPDATE_VIEW_DEFAULT_DESCRIPTION_BREAK="*Extensions marked with <span class='label label-important'>No</span> or <span class='label'>Missing Compatibility Tag</span> might break your website. Please consult with the developer before upgrading."
COM_JOOMLAUPDATE_VIEW_DEFAULT_DESCRIPTION_MISSING_TAG="*Extensions marked with <span class='label'>Missing Compatibility Tag</span> indicate the developer did not add a compatibility tag in the respective extension's XML."
COM_JOOMLAUPDATE_VIEW_DEFAULT_DESCRIPTION_UPDATE_REQUIRED="*Extensions marked with <span class='label label-warning'>Yes (X.X.X)</span> might require an update."
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2018
Category Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins JavaScript com_banners Administration com_banners com_joomlaupdate com_menus com_modules com_templates Language & Strings Front End com_contact com_content com_newsfeeds Layout JavaScript Modules Plugins
avatar Quy
Quy - comment - 22 May 2018

I have tested this item successfully on 59ed416


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20328.

avatar Quy Quy - test_item - 22 May 2018 - Tested successfully
avatar htmgarcia htmgarcia - change - 22 May 2018
Labels Added: ?
avatar wilsonge wilsonge - change - 14 Jun 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-06-14 22:36:45
Closed_By wilsonge
avatar wilsonge wilsonge - close - 14 Jun 2018
avatar wilsonge wilsonge - merge - 14 Jun 2018
avatar wilsonge
wilsonge - comment - 14 Jun 2018

Nice work! Thanks :)

Add a Comment

Login with GitHub to post a comment