User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Replace "label" classes (not available in Bootstrap 4) with the new "badge" ones in frontend and backend
You can test in several places.
As example. Preview single articles that include tags in frontend
The tags should have styling (color, background, etc) (with "badge" classes)
The tags looks like regular links (with "label" classes)
Replacing the "label" classes with "badge" ones. That summarize this PR.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Libraries Modules Plugins |
Title |
|
@brianteeman I didn't included any change related to the backend template.
Labels |
Added:
?
|
Category | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Libraries Modules Plugins | ⇒ | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins |
I have tested this item
Code review
Category | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins | ⇒ | Unit Tests Repository Administration com_admin SQL |
Labels |
Added:
?
|
Category | Administration Unit Tests Repository com_admin SQL | ⇒ | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins |
Labels |
Removed:
?
|
Resolved conflicts.
@ciar4n and @wilsonge do you really want to tightly couple the front end to Bootstrap? There is always the option to extend to some random unique class which will work nicely with but especially without Bootstrap (you can even keep the old classes and extend them to badge).
Personally I wouldn't tightly couple the FRONTEND core output to Bootstrap, it brings more limitations than the promised easiness of doing things. Also it's a no go if someone needs to build a fairly performant site, whatever that means according to the current benchmarking tools out there (google is probably installed in every client pc, so lighthouse is just a click away). Food for thought...
The badge/label utility class isn't going to "tightly couple the FRONTEND core output to Bootstrap".
Pick a standard, stick with it, or say "screw every existing standard" and write the Joomla CSS Framework already.
@htmgarcia it can't be merged until it passes all the tests
@brianteeman This PR is just about replacing "label" as classname in the HTML. Nothing fancy.
Sorry. I don't follow the 2 fails on the checks. Any idea what's the issue with these failed checks?
At this stage it is safe to say we are not going to be creating our own CSS framework. Prefixing one of the current standards (eg Bootstrap) is the only viable option IF we want to decouple the views from Bootstrap. To do that we either
I've looked in to the second option (the ideal of the 2) however the automated prefixing modules I've tested to date do not play nice with SCSS @extend
s which pretty much rules out using Bootstrap. Most other frameworks avoid @extend
(https://csswizardry.com/2016/02/mixins-better-for-performance/).
@brianteeman @wilsonge may we merge this one, pretty please?
@htmgarcia it can't be merged until it passes all the tests
it still has zero user tests
tests are reset when the code changes which you did when you resolved the conflicts
Category | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins | ⇒ | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout JavaScript Modules Plugins |
There are 3 more in the screenshot that have to be replaced.
Category | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins JavaScript | ⇒ | Administration com_banners com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout JavaScript Modules Plugins |
Sorry these should be the last ones.
COM_JOOMLAUPDATE_VIEW_DEFAULT_DESCRIPTION_BREAK="*Extensions marked with <span class='label label-important'>No</span> or <span class='label'>Missing Compatibility Tag</span> might break your website. Please consult with the developer before upgrading."
COM_JOOMLAUPDATE_VIEW_DEFAULT_DESCRIPTION_MISSING_TAG="*Extensions marked with <span class='label'>Missing Compatibility Tag</span> indicate the developer did not add a compatibility tag in the respective extension's XML."
COM_JOOMLAUPDATE_VIEW_DEFAULT_DESCRIPTION_UPDATE_REQUIRED="*Extensions marked with <span class='label label-warning'>Yes (X.X.X)</span> might require an update."
Category | Administration com_joomlaupdate com_menus com_modules com_templates Front End com_contact com_content com_newsfeeds Layout Modules Plugins JavaScript com_banners | ⇒ | Administration com_banners com_joomlaupdate com_menus com_modules com_templates Language & Strings Front End com_contact com_content com_newsfeeds Layout JavaScript Modules Plugins |
I have tested this item
Labels |
Added:
?
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-06-14 22:36:45 |
Closed_By | ⇒ | wilsonge |
Nice work! Thanks :)
Can you please check in this repo where the admin template etc is being developed as I believe this has already been done https://github.com/joomla/40-backend-template/