[#20314] - Switcher parameter style works odd (Joomla 4)
- Closed
- 7 May 2018
- Medium
- Build: staging
- # 20314
Steps to reproduce the issue
If you are adding a radio parameter using the switcher class (in this case for a template through the file templateDetails.xml)
<field
name="something"
type="radio"
class="switcher"
default="0"
label="Something">
<option value="1">Yes</option>
<option value="0">No</option>
</field>
Expected result
The switcher should be in gray color when the default value is 0 ("No")
The switcher should be in green color when the default value is 1 ("Yes")
Actual result
The switcher is in green color when the default value is 0 ("No")
The switcher is in gray color when the default value is 1 ("Yes")
System information (as much as possible)
Chrome Version 66.0.3359.139 (Official Build) (64-bit)
MacOS High Sierra 10.13.4
Additional comments
It seems that the order of the options would make the switcher to works fine:
<option value="0">No</option>
<option value="1">Yes</option>
In the other side, if the options are listed with "1" as first, is when doesn't work:
<option value="1">Yes</option>
<option value="0">No</option>
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
Thanks @dgrammatiko !
Closing. This issue was already reported joomla/40-backend-template#395 (comment)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-07 21:43:49 |
| Closed_By | ⇒ | htmgarcia |
The normal approach for the Switcher would be (note the order of the options)
<option value="0">No</option>
<option value="1">Yes</option>
This would result in: No (grey) and Yes (green).
If you don't want "Yes" to be green, or is not the recommended setting, you can add a class to the XML field, like so:
<field
type="radio"
class="switcher switcher-danger"
You cannot "patch" this simply because it may not always be the case where the user uses the values 0 and 1 or the text No and Yes. They may very well go with:
<option value="foo">Apples</option>
<option value="bar">Pears</option>
I will try to fix this in joomla/40-backend-template#395