Summary of Changes

Changed the loadFormData to cast $data to an object (in com_menus/item and com_banners/download). All other components/models use an object when calling $this->preprocessData, com_menu and com_banner (and these specific models) seem to be the only exceptions. These changes should have no negative effect on existing code. This change is required to be able to alter the data of the JForm because the original array will not be modified (an object will however).

Testing Instructions

1. Open the file plugins/system/stats/stats.php
2. Add these lines after line 22

 public function onContentPrepareData($context, $data)
    {
        $data['title'] = "foo";
    }

3. Go in the backend to a menu-item (here I open a menu item called Login)
4. Notice how the title remains unchanged

5. Apply the patch
6. Change the code in stats.php to look like the following

 public function onContentPrepareData($context, $data)
    {
        $data->title = "foo";
    }

7. Now reload the menu item page and see the title is changed

To test this with the banners fix, do the following:

1. Open the file plugins/system/stats/stats.php
2. Add these lines after line 22

 public function onContentPrepareData($context, $data)
    {
        $data['basename'] = "foo";
    }

3. Go in the backend to Banners -> Tracks
4. Click on Export
5. The modal shows the File Name as SITE instead of foo

6. Close the modal
7. Change the code in stats.php to look like the following

 public function onContentPrepareData($context, $data)
    {
        $data->basename = "foo";
    }

8. Now click on the Export button again and notice the File Name is changed to foo

Now both have been successfully tested

Expected result

Title of menu-item is changed to "foo"

Actual result

Title remains unchanged

Documentation Changes Required

None