J4 Issue ?
avatar infograf768
infograf768
7 May 2018

Steps to reproduce the issue

I remarked these strings in installation/language/en-GB/en-GB.ini

; Field password messages
JFIELD_PASSWORD_INDICATE_INCOMPLETE="Password doesn't meet site's requirements"
JFIELD_PASSWORD_INDICATE_COMPLETE="Password accepted"
JFIELD_PASSWORD_NOTE_LBL="Password must contain:"
JFIELD_PASSWORD_NOTE_DESC="%1 symbol(s), %2 uppercase letter(s), %3 lowercase letter(s), %4 number(s)"

If anyone who added these strings intends to use them, I would be curious about the way that person intended to code as obviously the variables can't be set by the person installing Joomla.

Maybe the variable would get hardcoded default values (which could be overriden by custom distros in installation/localise.xml) ? Strings anyway would have to be modified.

If it is just one of these mistakes (it happens), I rather suggest to add a note asking the SuperUser to set the rules and modify her/his password once J is installed.

or just delete these strings.

avatar infograf768 infograf768 - open - 7 May 2018
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 7 May 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 May 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 May 2018
Category com_installer
avatar brianteeman brianteeman - change - 8 May 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 8 May 2018
avatar laoneo
laoneo - comment - 9 May 2018

If they are not used, then remove them.

avatar infograf768
infograf768 - comment - 9 May 2018

@laoneo
I think it's a pity not to include a password check when installing Joomla (using hardcoded values and these modified strings .Password doesn't meet site's requirements would not fit) OR at least inform whoever is installing joomla to modify that super user password asap after install.

As it is today, we still can install using admin/admin (convenient for testers, but not good for online sites) and forget about it.

avatar brianteeman
brianteeman - comment - 9 May 2018

i think its less of an unused string and more of a feature not yet implement by @dgrammatiko in the installer

avatar Quy Quy - change - 13 Dec 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-12-13 15:45:52
Closed_By Quy
avatar Quy Quy - close - 13 Dec 2019
avatar brianteeman
brianteeman - comment - 13 Dec 2019

Please re-open as I closed the PR

avatar Quy Quy - change - 13 Dec 2019
Status Closed Pending
Closed_Date 2019-12-13 15:45:52
Closed_By Quy
avatar Quy Quy - reopen - 13 Dec 2019
avatar Quy
Quy - comment - 3 Sep 2020

Strings can be removed per PR #30402?

avatar infograf768
infograf768 - comment - 3 Sep 2020

Strings can be removed per PR #30402?

Yep, it looks like indeed.

avatar infograf768
infograf768 - comment - 3 Sep 2020

Others too as the password parameters are not set at installation time.

These should be kept
JFIELD_PASSWORD_SPACES_IN_PASSWORD="Password must not have spaces at the beginning or end."
JFIELD_PASSWORD_TOO_LONG="Password is too long. Passwords must be less than 100 characters."

But we can get rid of

JFIELD_PASSWORD_INDICATE_COMPLETE="Password accepted"
JFIELD_PASSWORD_INDICATE_INCOMPLETE="Password doesn't meet site's requirements."
JFIELD_PASSWORD_NOT_ENOUGH_INTEGERS_N="Password does not have enough digits. At least %s digits are required."
JFIELD_PASSWORD_NOT_ENOUGH_INTEGERS_N_1="Password does not have enough digits. At least 1 digit is required."
JFIELD_PASSWORD_NOT_ENOUGH_LOWERCASE_LETTERS_N="Password does not have enough lower case characters. At least %s lower case characters are required."
JFIELD_PASSWORD_NOT_ENOUGH_LOWERCASE_LETTERS_N_1="Password does not have enough lower case characters. At least 1 lower case character is required."
JFIELD_PASSWORD_NOT_ENOUGH_SYMBOLS_N="Password does not have enough symbols. At least %s symbols are required."
JFIELD_PASSWORD_NOT_ENOUGH_SYMBOLS_N_1="Password does not have enough symbols. At least 1 symbol is required."
JFIELD_PASSWORD_NOT_ENOUGH_UPPERCASE_LETTERS_N="Password does not have enough upper case characters. At least %s upper case characters are required."
JFIELD_PASSWORD_NOT_ENOUGH_UPPERCASE_LETTERS_N_1="Password does not have enough upper case characters. At least 1 upper case character is required."
JFIELD_PASSWORD_NOTE_DESC="%1 symbol(s), %2 uppercase letter(s), %3 lowercase letter(s), %4 number(s)"
JFIELD_PASSWORD_NOTE_LBL="Password must contain:"
avatar Quy
Quy - comment - 3 Sep 2020

Will you please do a PR? Thanks

avatar infograf768
infograf768 - comment - 3 Sep 2020

in fact we do need the 2 first strings as they are used under the meter.
Making PR now

avatar infograf768 infograf768 - change - 3 Sep 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-09-03 13:50:35
Closed_By infograf768
avatar infograf768
infograf768 - comment - 3 Sep 2020

PR: #30560
closing

avatar infograf768 infograf768 - close - 3 Sep 2020
avatar dgrammatiko
dgrammatiko - comment - 3 Sep 2020

The strings DO NOT belong to any of the apps (site, admin, install). They probably need their own file per field.
@laoneo had implemented a hook that allows 3rd PD to override any part of Joomla, meaning someone could override the whole JForm thus such strings shouldn't belong to the JApplication 's but rather to the field or the part that they actually belong.

Not to mention that you have the same strings 3x (site, admin, install)

My 2c

avatar infograf768
infograf768 - comment - 3 Sep 2020

Sorry, @dgrammatiko , had just done the Pr.
No idea what was done and where concerning the installation strings.
If they are linked to a specific field, I wonder how they would be included in language packs though.
Some information are welcome.

avatar dgrammatiko
dgrammatiko - comment - 3 Sep 2020

@infograf768 the PR is correct in the context of what the installation password field supports. What I was pointing out in my previous comment was that the language strings need a deeper evaluation, having identical strings in 2-3 different places is a maintenance nightmare.
Not asking you to come up with a solution tho, just pointing out something obvious...

avatar infograf768
infograf768 - comment - 3 Sep 2020

@dgrammatiko
OK
While you are here, could you check what I discovered concerning the metadata?
#30554 (comment)

Add a Comment

Login with GitHub to post a comment