I remarked these strings in installation/language/en-GB/en-GB.ini
; Field password messages
JFIELD_PASSWORD_INDICATE_INCOMPLETE="Password doesn't meet site's requirements"
JFIELD_PASSWORD_INDICATE_COMPLETE="Password accepted"
JFIELD_PASSWORD_NOTE_LBL="Password must contain:"
JFIELD_PASSWORD_NOTE_DESC="%1 symbol(s), %2 uppercase letter(s), %3 lowercase letter(s), %4 number(s)"
If anyone who added these strings intends to use them, I would be curious about the way that person intended to code as obviously the variables can't be set by the person installing Joomla.
Maybe the variable would get hardcoded default values (which could be overriden by custom distros in installation/localise.xml) ? Strings anyway would have to be modified.
If it is just one of these mistakes (it happens), I rather suggest to add a note asking the SuperUser to set the rules and modify her/his password once J is installed.
or just delete these strings.
Labels |
Added:
?
|
Status | New | ⇒ | Discussion |
Category | ⇒ | com_installer |
Labels |
Added:
J4 Issue
|
@laoneo
I think it's a pity not to include a password check when installing Joomla (using hardcoded values and these modified strings .Password doesn't meet site's requirements
would not fit) OR at least inform whoever is installing joomla to modify that super user password asap after install.
As it is today, we still can install using admin/admin (convenient for testers, but not good for online sites) and forget about it.
i think its less of an unused string and more of a feature not yet implement by @dgrammatiko in the installer
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-13 15:45:52 |
Closed_By | ⇒ | Quy |
Please re-open as I closed the PR
Status | Closed | ⇒ | Pending |
Closed_Date | 2019-12-13 15:45:52 | ⇒ | |
Closed_By | Quy | ⇒ |
Others too as the password parameters are not set at installation time.
These should be kept
JFIELD_PASSWORD_SPACES_IN_PASSWORD="Password must not have spaces at the beginning or end."
JFIELD_PASSWORD_TOO_LONG="Password is too long. Passwords must be less than 100 characters."
But we can get rid of
JFIELD_PASSWORD_INDICATE_COMPLETE="Password accepted"
JFIELD_PASSWORD_INDICATE_INCOMPLETE="Password doesn't meet site's requirements."
JFIELD_PASSWORD_NOT_ENOUGH_INTEGERS_N="Password does not have enough digits. At least %s digits are required."
JFIELD_PASSWORD_NOT_ENOUGH_INTEGERS_N_1="Password does not have enough digits. At least 1 digit is required."
JFIELD_PASSWORD_NOT_ENOUGH_LOWERCASE_LETTERS_N="Password does not have enough lower case characters. At least %s lower case characters are required."
JFIELD_PASSWORD_NOT_ENOUGH_LOWERCASE_LETTERS_N_1="Password does not have enough lower case characters. At least 1 lower case character is required."
JFIELD_PASSWORD_NOT_ENOUGH_SYMBOLS_N="Password does not have enough symbols. At least %s symbols are required."
JFIELD_PASSWORD_NOT_ENOUGH_SYMBOLS_N_1="Password does not have enough symbols. At least 1 symbol is required."
JFIELD_PASSWORD_NOT_ENOUGH_UPPERCASE_LETTERS_N="Password does not have enough upper case characters. At least %s upper case characters are required."
JFIELD_PASSWORD_NOT_ENOUGH_UPPERCASE_LETTERS_N_1="Password does not have enough upper case characters. At least 1 upper case character is required."
JFIELD_PASSWORD_NOTE_DESC="%1 symbol(s), %2 uppercase letter(s), %3 lowercase letter(s), %4 number(s)"
JFIELD_PASSWORD_NOTE_LBL="Password must contain:"
Will you please do a PR? Thanks
in fact we do need the 2 first strings as they are used under the meter.
Making PR now
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-03 13:50:35 |
Closed_By | ⇒ | infograf768 |
The strings DO NOT belong to any of the apps (site, admin, install). They probably need their own file per field.
@laoneo had implemented a hook that allows 3rd PD to override any part of Joomla, meaning someone could override the whole JForm thus such strings shouldn't belong to the JApplication 's but rather to the field or the part that they actually belong.
Not to mention that you have the same strings 3x (site, admin, install)
My 2c
Sorry, @dgrammatiko , had just done the Pr.
No idea what was done and where concerning the installation strings.
If they are linked to a specific field, I wonder how they would be included in language packs though.
Some information are welcome.
@infograf768 the PR is correct in the context of what the installation password field supports. What I was pointing out in my previous comment was that the language strings need a deeper evaluation, having identical strings in 2-3 different places is a maintenance nightmare.
Not asking you to come up with a solution tho, just pointing out something obvious...
@dgrammatiko
OK
While you are here, could you check what I discovered concerning the metadata?
#30554 (comment)
If they are not used, then remove them.