J4 Issue ?
avatar C-Lodder
C-Lodder
8 May 2018

Steps to reproduce the issue

In the Joomla backend, go to any list view, such as the Article or Module Manager.

Expected result

Any icons within the list are displayed correctly

Actual result

Small styling issue:
screeny

System information (as much as possible)

Joomla 4.0-dev

avatar C-Lodder C-Lodder - open - 8 May 2018
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 May 2018
avatar C-Lodder C-Lodder - change - 8 May 2018
The description was changed
avatar C-Lodder C-Lodder - edited - 8 May 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 May 2018
Category Layout Templates (admin)
avatar franz-wohlkoenig franz-wohlkoenig - change - 8 May 2018
Status New Discussion
avatar dgrammatiko
dgrammatiko - comment - 8 May 2018

I was about to make a PR removing the font awesome (the font) and start using the svgs (lazy loaded, cached), based on https://codepen.io/dgt41/pen/jxrwJE and as demonstrated in dgrammatiko.online (part of my JAB talk) but my phpstorm license expired...
BTW @ciar4n also agrees on the approach, as we effectively decouple joomla from font awesome but still use it!

avatar infograf768
infograf768 - comment - 8 May 2018

Let's be carefull with lazy-loading, if it applies here.
See https://forum.joomla.org/viewtopic.php?f=711&t=961813

avatar dgrammatiko
dgrammatiko - comment - 8 May 2018

@infograf768 that's totally irrelevant and also lazy loading is the best practice for all assets

avatar infograf768
infograf768 - comment - 8 May 2018

That is why I wrote

if it applies here.

avatar brianteeman brianteeman - change - 8 May 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 8 May 2018
avatar ciar4n
ciar4n - comment - 21 May 2018

PR created... #20514

avatar brianteeman brianteeman - change - 21 May 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-05-21 12:25:38
Closed_By brianteeman
avatar brianteeman brianteeman - close - 21 May 2018

Add a Comment

Login with GitHub to post a comment