[#20225] - Fix up the beez3 template.js
- Fixed in Code Base
- 5 Dec 2019
- Medium
- Build: staging
- # 20225
- Diff
- okonomiyaki3000:beez3-template-js
- Success Hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Don't use unnecessary closure, just use jQuery ready function.
Use javsacript strict mode
use event delegation where possible
Make tooltips and button groups work properly with repeatable subforms
Testing Instructions
Use beez3.
Create a page with a repeatable subform containing a radiobutton field with the btn-group class.
Expected result
Expect newly created rows to initialize btn-groups properly.
Actual result
Yes, it works.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Front End Templates (site) |
I have tested this item
Fails with error:
ReferenceError: label is not defined template.js:14:8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20225.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20225.
Just as a hint for testers (Beez doesn't load Bootstrap css always):
Deactivate this line before tests:
https://github.com/joomla/joomla-cms/blob/staging/templates/beez3/index.php#L41
to get the buttons styled correctly. Subforms don't look nice then but it is sufficient to test the concern of this pr.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20225.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20225.
| Labels |
Added:
?
|
||
It took some time to merge but thanks for you fix.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-05 22:44:36 |
| Closed_By | ⇒ | HLeithner |
This basically an alternative to #19722 with additional improvements and cleanup.