Feeling Lucky
?
[#20224] - Fix up the protostar template.js
- Fixed in Code Base
- 15 May 2018
- Medium
- Build: staging
- # 20224
- Diff
- okonomiyaki3000:protostar-template-js
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Don't use unnecessary closure, just use jQuery ready function.
Use javsacript strict mode
use event delegation where possible
Make tooltips and button groups work properly with repeatable subforms
Testing Instructions
Use protostar.
Create a page with a repeatable subform containing a radiobutton field with the btn-group class.
Expected result
Expect newly created rows to initialize btn-groups properly.
Actual result
Yes, it works.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Front End Templates (site) |
ReLater
- comment
- 24 Apr 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20224.
Quy
- comment
- 14 May 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20224.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 14 May 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20224.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-15 22:57:26 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
This basically an alternative to #19722 with additional improvements and cleanup.