It would be nice to hide Hide all messages button when there are no messages to hide.

I knew someone would say that.. I did have a quick look but didn’t spend any time on it, I’ll have a more in-depth look.

On 21 Mar 2018, 15:30 +0000, Quy notifications@github.com, wrote:

It would be nice to hide Hide all messages button when there are no messages to hide.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Tried that, items doesn’t exist at this point it happens on the parent.

On 21 Mar 2018, 15:34 +0000, Dimitri Grammatikogianni notifications@github.com, wrote:

@dgt41 commented on this pull request.
In administrator/components/com_postinstall/views/messages/view.html.php:

@@ -41,6 +41,7 @@ protected function onBrowse($tpl = null)
$this->extension_options = $model->getComponentOptions();

           JToolBarHelper::title(JText::sprintf('COM_POSTINSTALL_MESSAGES_TITLE', $model->getExtensionName($this->eid)));

•           JToolbarHelper::custom('hideAll', 'unpublish.png', 'unpublish_f2.png', 'COM_POSTINSTALL_HIDE_ALL_MESSAGES', false);
  

Wrap this line in an if statement if (!empty($this->items))
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Tried that, items doesn’t exist at this point it happens on the parent.

Then it needs to be done client side...

hence my point of only looking at it quickly ;-) and will sort it shortly.

On 21 Mar 2018, 15:37 +0000, Dimitri Grammatikogianni notifications@github.com, wrote:

Tried that, items doesn’t exist at this point it happens on the parent.
Then it needs to be done client side...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Is this really a good idea. Don't we want users to have to read each one?

@brianteeman and they do in the overview, but with the current UX you must click a button and reload the page for every one. This allows you to hide them all once you have read them.

On 21 Mar 2018, 15:38 +0000, Brian Teeman notifications@github.com, wrote:

Is this really a good idea. Don't we want users to have to read each one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks Quy, now done. Funnily enough phpcs didn’t pick it up :/ must make sure it’s up to date!

On 21 Mar 2018, 15:55 +0000, Quy notifications@github.com, wrote:

@Quy commented on this pull request.
In administrator/components/com_postinstall/views/messages/view.html.php:

• • @return boolean Return true to allow rendering of the page

•    *
  

•    * @since   __DEPLOY_VERSION__
  

•    */
  

•   protected function onDisplay($tpl = null)
  

•   {
  

•           $return = parent::onDisplay($tpl);
  

•           if (!empty($this->items))
  

•           {
  

•                   JToolbarHelper::custom('hideAll', 'unpublish.png', 'unpublish_f2.png', 'COM_POSTINSTALL_HIDE_ALL_MESSAGES', false);
  

•           }
  

•           return $return;
  

•   }
  

Remove blank lines.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I have tested this item ✅ successfully on f83d9ff

With Hathor template, the Hide all messages button is non-responsive.

That will be the same for any custom Joomla! Jtoolbar Button then? We are just calling the standard jtoolbar custom button?

And people still use Hathor?

On 21 Mar 2018, 21:34 +0000, Quy notifications@github.com, wrote:

With Hathor template, the Hide all messages button is non-responsive.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

We don't support new features in hathor

Good point, I just copied the reset function ? I’ll update both

On 22 Mar 2018, 07:22 +0000, Nicola Galgano notifications@github.com, wrote:

@alikon commented on this pull request.
In administrator/components/com_postinstall/models/messages.php:

• /**

•    * Hides all messages for an extension
  

•    *
  

•    * @param   integer  $eid  The extension ID whose messages we'll hide
  

•    *
  

•    * @return  mixed  False if we fail, a db cursor otherwise
  

•    *
  

•    * @since   __DEPLOY_VERSION__
  

•    */
  

•   public function hideMessages($eid)
  

•   {
  

•           $db = $this->getDbo();
  

•           $query = $db->getQuery(true)
  

•                   ->update($db->qn('#__postinstall_messages'))
  

•                   ->set($db->qn('enabled') . ' = ' . $db->q(0))
  

the fields enabled and extensions_id are declared as integer so don't quote
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ggppdk could you be so kind to run a test on this also? :-)

@ALL now updated as per @ggppdk comments. Can we get some tests pretty please.

I have tested this item ✅ successfully on ac42d2b

Hi,
I have tested this item successfully on #19958

Hello @jcata can you please mark succesfull here:https://issues.joomla.org/tracker/joomla-cms/19958

@jcata how to mark your Test as successfully:

• open Issue Tracker
• Login with your github-Account
• Click on blue "Test this"-Button above Authors-Picture
• mark your Test as successfully
• hit "submit test result"

I have tested this item ✅ successfully on ac42d2b

Hi guys, I've tested this patch and is ok

I have tested this item ✅ successfully on ac42d2b

Hi guys, I've tested this patch and is ok

Ready to Commit after two successful tests.