? ? ? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
21 Mar 2018

At present, the user has to click each message to hide them, which isn't very UX. This is a simple button which marks all the post install messages for the current extension as read.

Apply patch, you should see a Hide all messages button (top left). clicking it hides all messages. You can show them again by clicking the reset button in the middle of the page.

avatar tonypartridge tonypartridge - open - 21 Mar 2018
avatar tonypartridge tonypartridge - change - 21 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2018
Category Administration com_postinstall Language & Strings
avatar tonypartridge tonypartridge - change - 21 Mar 2018
Labels Added: ? ?
avatar Quy
Quy - comment - 21 Mar 2018

It would be nice to hide Hide all messages button when there are no messages to hide.

avatar tonypartridge
tonypartridge - comment - 21 Mar 2018

I knew someone would say that.. I did have a quick look but didn’t spend any time on it, I’ll have a more in-depth look.

On 21 Mar 2018, 15:30 +0000, Quy notifications@github.com, wrote:

It would be nice to hide Hide all messages button when there are no messages to hide.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar tonypartridge
tonypartridge - comment - 21 Mar 2018

Tried that, items doesn’t exist at this point it happens on the parent.

On 21 Mar 2018, 15:34 +0000, Dimitri Grammatikogianni notifications@github.com, wrote:

@dgt41 commented on this pull request.
In administrator/components/com_postinstall/views/messages/view.html.php:

@@ -41,6 +41,7 @@ protected function onBrowse($tpl = null)
$this->extension_options = $model->getComponentOptions();

           JToolBarHelper::title(JText::sprintf('COM_POSTINSTALL_MESSAGES_TITLE', $model->getExtensionName($this->eid)));
  •           JToolbarHelper::custom('hideAll', 'unpublish.png', 'unpublish_f2.png', 'COM_POSTINSTALL_HIDE_ALL_MESSAGES', false);
    

Wrap this line in an if statement if (!empty($this->items))

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar dgt41
dgt41 - comment - 21 Mar 2018

Tried that, items doesn’t exist at this point it happens on the parent.

Then it needs to be done client side...

avatar tonypartridge
tonypartridge - comment - 21 Mar 2018

hence my point of only looking at it quickly ;-) and will sort it shortly.

On 21 Mar 2018, 15:37 +0000, Dimitri Grammatikogianni notifications@github.com, wrote:

Tried that, items doesn’t exist at this point it happens on the parent.
Then it needs to be done client side...

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar brianteeman
brianteeman - comment - 21 Mar 2018

Is this really a good idea. Don't we want users to have to read each one?

avatar tonypartridge
tonypartridge - comment - 21 Mar 2018

@brianteeman and they do in the overview, but with the current UX you must click a button and reload the page for every one. This allows you to hide them all once you have read them.

On 21 Mar 2018, 15:38 +0000, Brian Teeman notifications@github.com, wrote:

Is this really a good idea. Don't we want users to have to read each one?

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar tonypartridge
tonypartridge - comment - 21 Mar 2018

Thanks Quy, now done. Funnily enough phpcs didn’t pick it up :/ must make sure it’s up to date!

On 21 Mar 2018, 15:55 +0000, Quy notifications@github.com, wrote:

@Quy commented on this pull request.
In administrator/components/com_postinstall/views/messages/view.html.php:

    • @return boolean Return true to allow rendering of the page
  •    *
    
  •    * @since   __DEPLOY_VERSION__
    
  •    */
    
  •   protected function onDisplay($tpl = null)
    
  •   {
    
  •           $return = parent::onDisplay($tpl);
    
  •           if (!empty($this->items))
    
  •           {
    
  •                   JToolbarHelper::custom('hideAll', 'unpublish.png', 'unpublish_f2.png', 'COM_POSTINSTALL_HIDE_ALL_MESSAGES', false);
    
  •           }
    
  •           return $return;
    
  •   }
    

Remove blank lines.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Quy
Quy - comment - 21 Mar 2018

I have tested this item successfully on f83d9ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19958.

avatar Quy Quy - test_item - 21 Mar 2018 - Tested successfully
avatar Quy
Quy - comment - 21 Mar 2018

With Hathor template, the Hide all messages button is non-responsive.

avatar tonypartridge
tonypartridge - comment - 21 Mar 2018

That will be the same for any custom Joomla! Jtoolbar Button then? We are just calling the standard jtoolbar custom button?

And people still use Hathor?

On 21 Mar 2018, 21:34 +0000, Quy notifications@github.com, wrote:

With Hathor template, the Hide all messages button is non-responsive.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar brianteeman
brianteeman - comment - 21 Mar 2018

We don't support new features in hathor

avatar tonypartridge
tonypartridge - comment - 22 Mar 2018

Good point, I just copied the reset function 🤪 I’ll update both

On 22 Mar 2018, 07:22 +0000, Nicola Galgano notifications@github.com, wrote:

@alikon commented on this pull request.
In administrator/components/com_postinstall/models/messages.php:

  • /**
  •    * Hides all messages for an extension
    
  •    *
    
  •    * @param   integer  $eid  The extension ID whose messages we'll hide
    
  •    *
    
  •    * @return  mixed  False if we fail, a db cursor otherwise
    
  •    *
    
  •    * @since   __DEPLOY_VERSION__
    
  •    */
    
  •   public function hideMessages($eid)
    
  •   {
    
  •           $db = $this->getDbo();
    
  •           $query = $db->getQuery(true)
    
  •                   ->update($db->qn('#__postinstall_messages'))
    
  •                   ->set($db->qn('enabled') . ' = ' . $db->q(0))
    

the fields enabled and extensions_id are declared as integer so don't quote

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar tonypartridge
tonypartridge - comment - 25 Mar 2018

@ggppdk could you be so kind to run a test on this also? :-)

avatar tonypartridge
tonypartridge - comment - 27 Mar 2018

@ALL now updated as per @ggppdk comments. Can we get some tests pretty please.

avatar Quy
Quy - comment - 28 Mar 2018

I have tested this item successfully on ac42d2b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19958.

avatar Quy Quy - test_item - 28 Mar 2018 - Tested successfully
avatar jcata
jcata - comment - 28 Mar 2018

Hi,
I have tested this item successfully on #19958

avatar tonypartridge
tonypartridge - comment - 28 Mar 2018

Hello @jcata can you please mark succesfull here:https://issues.joomla.org/tracker/joomla-cms/19958

avatar tonypartridge tonypartridge - change - 28 Mar 2018
The description was changed
avatar tonypartridge tonypartridge - edited - 28 Mar 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Mar 2018

@jcata how to mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar jcata
jcata - comment - 28 Mar 2018

I have tested this item successfully on ac42d2b

Hi guys, I've tested this patch and is ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19958.

avatar jcata
jcata - comment - 28 Mar 2018

I have tested this item successfully on ac42d2b

Hi guys, I've tested this patch and is ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19958.

avatar jcata jcata - test_item - 28 Mar 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Mar 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 29 Mar 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-29 11:53:16
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Mar 2018
avatar mbabker mbabker - merge - 29 Mar 2018

Add a Comment

Login with GitHub to post a comment