? ? Pending

User tests: Successful: Unsuccessful:

avatar Wang-Yu-Chao
Wang-Yu-Chao
21 Mar 2018

Pull Request for Issue # .

Summary of Changes

In class Registry, function set() is supposed to return the old value if exists, but actually return the newly set value.

Testing Instructions

None

Expected result

None

Actual result

None

Documentation Changes Required

None

avatar Wang-Yu-Chao Wang-Yu-Chao - open - 21 Mar 2018
avatar Wang-Yu-Chao Wang-Yu-Chao - change - 21 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2018
Category External Library Libraries Composer Change
avatar mbabker
mbabker - comment - 21 Mar 2018

This'll actually need to be fixed in the upstream repo (https://github.com/joomla-framework/registry) and at this point I'd suggest we could only fix this in that repo's 2.0 branch because it is a B/C breaking change in the current code behavior (even if the actual behavior goes against the documentation).

avatar Wang-Yu-Chao
Wang-Yu-Chao - comment - 21 Mar 2018

Got it. Gonna fix this in that repo

avatar Wang-Yu-Chao Wang-Yu-Chao - change - 21 Mar 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-03-21 16:37:38
Closed_By Wang-Yu-Chao
Labels Added: ? ?
avatar Wang-Yu-Chao Wang-Yu-Chao - close - 21 Mar 2018

Add a Comment

Login with GitHub to post a comment