[#19957] - [4.0] Fix the web components
- Fixed in Code Base
- 22 Mar 2018
- Medium
- Build: 4.0-dev
- # 19957
- Diff
- dgt41:html/fix-wc
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
-
The method
HTMLHelper::webcomponent()is a little different than the script or stylesheet. This PR aligns it (basically the first param was an array and now is just the script path to be included). -
This also assures that web components won't get loaded multiple times!
Testing Instructions
Apply patch, go to the backend and observe that alerts, switcher, media field and user field are still working!
Expected result
Actual result
Documentation Changes Required
Yes, a note here, using the same params as script and stylesheet is a good thing and also helpful for all devs since they don't have to remember that this method is weird and needs something different.
@wilsonge this is essential, I've got it wrong here
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Templates (admin) Installation Layout Libraries JavaScript Front End Templates (site) |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-22 13:11:33 |
| Closed_By | ⇒ | wilsonge |