? ? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
20 Mar 2018

Fix for duplicate url check bug introduced by #19734 and support utf8 on old_urls.
Couldn't find a solution to handle this within mysql. So a simple foreach handles it perfectly fine.

@infograf768 can you please test?

avatar tonypartridge tonypartridge - open - 20 Mar 2018
avatar tonypartridge tonypartridge - change - 20 Mar 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2018
Category Administration com_redirect
avatar infograf768
infograf768 - comment - 20 Mar 2018

I have tested this item successfully on dc2021a

Great!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19950.

avatar infograf768
infograf768 - comment - 20 Mar 2018

I have tested this item successfully on dc2021a

Great!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19950.

avatar infograf768 infograf768 - test_item - 20 Mar 2018 - Tested successfully
avatar Quy
Quy - comment - 20 Mar 2018

I have tested this item successfully on dc2021a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19950.

avatar Quy Quy - test_item - 20 Mar 2018 - Tested successfully
avatar tonypartridge tonypartridge - change - 20 Mar 2018
Labels Added: ?
avatar tonypartridge
tonypartridge - comment - 20 Mar 2018

Done

On 20 Mar 2018, 22:46 +0000, Quy notifications@github.com, wrote:

@Quy commented on this pull request.
In administrator/components/com_redirect/tables/link.php:

  •           $xid = (int) $db->loadResult();
    
  •           if ($xid && $xid != (int) $this->id)
    
  •           foreach ($urls AS $url)
    

Change AS to as

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar Quy Quy - change - 20 Mar 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 20 Mar 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19950.

avatar mbabker mbabker - change - 25 Mar 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-03-25 14:59:36
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 25 Mar 2018
avatar mbabker mbabker - merge - 25 Mar 2018

Add a Comment

Login with GitHub to post a comment