Feeling Lucky
?
[#19951] - Update tag.php
- Fixed in Code Base
- 18 May 2018
- Medium
- Build: staging
- # 19951
- Diff
- xabispacebiker:patch-1
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
There is a bug in getItem, the function parameter is called $pk, but in code it is using $id, so whenever the parameter is passed it is not used in the function.
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
Quy
- comment
- 12 May 2018
I have tested this item
Install demo.
In the frontend, click Tagged items link.
It should work the same as before. Basically, $id is undefined and $pk is null so the if statement will be executed in both cases.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19951.
carlitorweb
- comment
- 16 May 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19951.
Tested following the instructions of @Quy
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 16 May 2018
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19951.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-18 11:14:47 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
from a code review it seems that you are right,
but please, add some Testing Instructions..