[#19949] - [Regression] Menu item type url with rel attribute nofollow
- Fixed in Code Base
- 24 May 2018
- Medium
- Build: staging
- # 19949
- Diff
- Devportobello:menuitemurlrelnofollow
User tests: Successful: Unsuccessful:
Following PR #14881
Previous PR (#14881) adding regression about menu item "url", when choosing "nofollow" for "Link Rel Attribute" and "New window with navigation" for "Target window", the value "nofollow" is not added, because of https://github.com/joomla/joomla-cms/blob/staging/modules/mod_menu/tmpl/default_url.php#L52 [https://github.com/joomla/joomla-cms/pull/14881/files#diff-c0c6261ed88c7b7315ee79638a3917abR44]
Testing Instructions
Create a new menu item > Type : URL
- Target window : "new window with navigation"
- Link rel attribute : "nofollow"
Frontend > look at menu item, there is no "nofollow" in rel attribute
Apply patch
Frontend > look at menu item, this works
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
@Quy
thx pointing me cs fix, will do
@infograf768
My PR add "nofollow" only if user want it, if he choose "nofollow" on "link rel attribute"
This is a regression about SEO */!*
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19949.
1 more human test to go :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19949.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19949.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-24 00:05:28 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Hmm, after re-reading #14881, it seems that some people there did not agree to add nofollow (don't ask me why).