Feeling Lucky
?
?
[#19623] - Use jasmine done helper when using setTimeout in tests
- Fixed in Code Base
- 8 Feb 2018
- Medium
- Build: 4.0-dev
- # 19623
- Diff
- dneukirchen:bugfix/fix-set-timeout-js-tests
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
The current tests are useless (they dont fail) and make it hard to debug failing tests.
Testing Instructions
- change expectations so that the tests should fail i.e. instead of
expect($("#system-message-container")).toBeEmpty();useexpect($("#system-message-container")).not.toBeEmpty();in calendar/spec.js line 205 - run tests => tests do not fail
- apply this patch and change expectation again
- run tests => tests fail (as expected)
Expected result
working tests
Actual result
useless tests
Documentation Changes Required
@astridx
https://docs.joomla.org/JavaScript_Tests_for_Joomla4 (code sample also has the error)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
astridx
- comment
- 8 Feb 2018
I fetched this branch and run the tests via
node_modules/karma/bin/karma start karma.conf.js --single-run > log.log
No error in the log.log
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-08 17:35:15 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
@rdeutz are you around the green merge button?