Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19622] - [4.0] Move inline onclick handler to js script

? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
8 Feb 2018

Moves the onclick code to the js script in finder.

Ping @dgt41.

avatar laoneo laoneo - open - 8 Feb 2018
avatar laoneo laoneo - change - 8 Feb 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2018
Category ⇒ Administration com_finder JavaScript
avatar laoneo laoneo - change - 9 Feb 2018
Labels Added: ?
avatar laoneo
laoneo - comment - 9 Feb 2018

Changed to forEach. Ready to merge.

avatar dneukirchen
dneukirchen - comment - 9 Feb 2018

  1. Its not safe to bind behavior to css classes. It will lead to conflicts with templates, modules or other scrips. Especially when they are commonly used like .toggle-all.

  2. Why are we triggering the click event on the checkbox instead of just checking it?

  3. Its a common task to check/uncheck checkboxes in joomla. We should have a global helper for it (and we already have one which is tightly coupled to the dom and not flexible enough. Yes, im looking at you Joomla.checkAll())

avatar laoneo
laoneo - comment - 9 Feb 2018

We are talking here only about a simple script in the finder component.

avatar laoneo laoneo - close - 9 Feb 2018
avatar laoneo laoneo - change - 9 Feb 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-09 16:26:04
Closed_By ⇒ laoneo
avatar laoneo laoneo - change - 12 Feb 2018
Status Closed ⇒ New
Closed_Date 2018-02-09 16:26:04 ⇒
Closed_By laoneo ⇒
avatar laoneo laoneo - change - 12 Feb 2018
Status New ⇒ Pending
avatar laoneo laoneo - change - 12 Feb 2018
Status Pending ⇒ Closed
avatar laoneo laoneo - reopen - 12 Feb 2018
avatar laoneo laoneo - close - 23 Feb 2018

Add a Comment

Login with GitHub to post a comment