[#19574] - [4.0] Enforced expected parameter type
- Closed
- 7 Feb 2018
- Medium
- Build: 4.0-dev
- # 19574
- Diff
- demis-palma:gettemplate-4
User tests: Successful: Unsuccessful:
Summary of Changes
The method getTemplate() implemented in CMSApplication, SiteApplication and AdministratorApplication wants a bool as unique parameter.
Currently there are a few occurrences where a string is passed instead, which incidentally assumes the intended value (true) when implicitly converted to bool:
(bool)'template' → true
Testing Instructions
To be merged on code review.
Fixed on staging too.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates Front End com_config |
I suspected something like this, but I wasn't sure because the patch is slightly different in the two branches.
Sorry for the mess and thanks for the information.
IMO this here can be closed as the other PR should be merged in 4.0 too by updating 4.0 with staging.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-07 00:06:15 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
FYI you don't need to do PRs for both 3.x (staging/3.9-dev) and 4.x (4.0-dev). Albeit slowly, stuff is getting merged from staging into both 3.9-dev and 4.0-dev branches, so if you fix an issue in one branch it'll get applied everywhere.