? Pending

User tests: Successful: Unsuccessful:

avatar demis-palma
demis-palma
5 Feb 2018

Summary of Changes

The method getTemplate() implemented in CMSApplication, SiteApplication and AdministratorApplication wants a bool as unique parameter.
Currently there are a few occurrences where a string is passed instead, which incidentally assumes the intended value (true) when implicitly converted to bool:
(bool)'template' → true

Testing Instructions

To be merged on code review.

Fixed on 4.0 too.

avatar demis-palma demis-palma - open - 5 Feb 2018
avatar demis-palma demis-palma - change - 5 Feb 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2018
Category Administration com_templates Front End com_config
avatar demis-palma demis-palma - change - 5 Feb 2018
The description was changed
avatar demis-palma demis-palma - edited - 5 Feb 2018
avatar demis-palma demis-palma - change - 5 Feb 2018
The description was changed
avatar demis-palma demis-palma - edited - 5 Feb 2018
avatar zero-24 zero-24 - change - 7 Feb 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-07 00:04:22
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 7 Feb 2018
avatar zero-24 zero-24 - merge - 7 Feb 2018
avatar zero-24
zero-24 - comment - 7 Feb 2018

Merged on review. Thanks.

Add a Comment

Login with GitHub to post a comment