Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19575] - [4.0] Correct the doc blocks of rules layout

? Pending

User tests: Successful: Unsuccessful:

avatar Anu1601CS
Anu1601CS
5 Feb 2018

Summary of Changes

Used variables explained in the doc block of the JLayout
And remove unwanted variables.

Testing Instructions

Code review

Expected result

Same as before

Actual result

Same as before

Documentation Changes Required

avatar Anu1601CS Anu1601CS - open - 5 Feb 2018
avatar Anu1601CS Anu1601CS - change - 5 Feb 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2018
Category ⇒ Layout Libraries
avatar Anu1601CS
Anu1601CS - comment - 5 Feb 2018

@dgt41 Please review

avatar Anu1601CS Anu1601CS - change - 5 Feb 2018
Title
…
[4.0] Correct the doc blocks
[4.0] Correct the doc blocks of rules layout
avatar Anu1601CS Anu1601CS - edited - 5 Feb 2018
avatar dgt41
dgt41 - comment - 5 Feb 2018

Looking good

avatar Anu1601CS
Anu1601CS - comment - 5 Feb 2018

@wilsonge take a look here which was left in #19507

avatar wilsonge wilsonge - change - 5 Feb 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-05 20:37:10
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 5 Feb 2018
avatar wilsonge wilsonge - merge - 5 Feb 2018
avatar wilsonge
wilsonge - comment - 5 Feb 2018

Looks good. One day I'll do a proper code review of the first PR ? ?

avatar Anu1601CS
Anu1601CS - comment - 5 Feb 2018

@wilsonge sure, it was necessary because this was my first time when I have written whole file code ??
If some mistake sorry for that
Thanks

Add a Comment

Login with GitHub to post a comment