Feeling Lucky
?
?
[#19534] - [4.0] Fix Codemirror
- Fixed in Code Base
- 5 Feb 2018
- Medium
- Build: 4.0-dev
- # 19534
- Diff
- dgt41:4.0-dev-codemirror-fix
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #19532
Summary of Changes
- Fix code mirror missing code from addons.js
- Also update cm to 5.34
- Update tinyMCE to 4.7.6
Testing Instructions
Apply patch and check if code mirror nd tinyMCE are ok
Expected result
No console errors:
Actual result
Documentation Changes Required
A note to all the maintainers or contributors that want to update npm dependencies in J4:
- You need to update the version number in package.json
- You need to run
node build --update - You need to run
node build --compilejs(to uglify the scripts) - You need to run
node build --compilecss(to minify the css files)
Then you're ready to commit these changes!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
dgt41
- comment
- 2 Feb 2018
@franz-wohlkoenig you need to install from the relative link on the tracker, as its already noted before patch tester will not always handle assets correctly
Anu1601CS
- comment
- 3 Feb 2018
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19534.
astridx
- comment
- 3 Feb 2018
I have tested this item
With this patch I can open and edit files in template manager on my ubuntu machine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19534.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 3 Feb 2018
Ready to Commit after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-05 00:25:26 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Tried to apply PR, got: