[#19533] - CodeMirror Updated to 5.34.0
- Fixed in Code Base
- 3 Feb 2018
- Medium
- Build: staging
- # 19533
- Diff
- okonomiyaki3000:CodeMirror-Update
User tests: Successful: Unsuccessful:
Pull Request for Issue #19520 .
Summary of Changes
See here: http://codemirror.net/doc/releases.html
Although not mentioned on the releases page, the previous version had a Typo that caused syntax coloring of PHP code to stop working. This is fixed in the new version.
Testing Instructions
Use codemirror.
Expected result
It will work as usual.
Actual result
It works as usual.
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript External Library |
@okonomiyaki3000 #19522 is same PR, should this one be closed as #19522 is RTC?
@franz-wohlkoenig the other way around as this is the official update from codemirror. We should never be changing upstream files ;)
#19522 is not needed if this is merged.
However, I should point out that it does not modify any upstream files. It does not fix codemirror's bug, it merely works around it. So merging that would potentially protect against the same or similar bug being introduced in a future version of codemirror.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19533.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have tested this item
Everything seems good in Joomla template manager,
Tested usage of code mirror in custom extension
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19533.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-03 17:12:56 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 2c0d2f4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19533.