? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
29 Jan 2018

Summary of Changes

I have corrected the path to the file joomla-alert.min.js in the file karma.conf.js

Testing Instructions

Run the tests via
node_modules/karma/bin/karma start karma.conf.js –single-run

Expected result

No warning

Actual result

You see the warning message
WARN [watcher]: Pattern "/var/www/html/JOOMLA/joomla4/joomla-cms/media/system/webcomponents/joomla-alert.min.js" does not match any file.

Documentation Changes Required

No

avatar astridx astridx - open - 29 Jan 2018
avatar astridx astridx - change - 29 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jan 2018
Category JavaScript Unit Tests
avatar Quy Quy - change - 29 Jan 2018
Title
correct path to node_modules/karma/bin/karma start karma.conf.js --si…
[4.0] correct path to node_modules/karma/bin/karma start karma.conf.js --si…
avatar joomla-cms-bot joomla-cms-bot - edited - 29 Jan 2018
avatar zero-24
zero-24 - comment - 29 Jan 2018

@wilsonge can you take a look into that. As drone fails on 4.0 only owner can merge here ?

avatar dgt41
dgt41 - comment - 30 Jan 2018

@astridx please check this: d9d988a
There are a bit more lines of definitions needed here

avatar astridx
astridx - comment - 30 Jan 2018

Close as it is part of another PR: #19426

avatar astridx astridx - change - 30 Jan 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-01-30 12:35:22
Closed_By astridx
Labels Added: ? ?
avatar astridx astridx - close - 30 Jan 2018

Add a Comment

Login with GitHub to post a comment