[#19480] - [4.0] Custom Elements: `Element#attachShadow` was not patched.
- Closed
- 30 Jan 2018
- Medium
- Build: staging
- # 19480
The issue #17914 described this warning first:
##Steps to reproduce the issue
- Enable Inspector in FireFox
- Go to the Control Panel
- Check the Console tab
- The notice is shown there
The issue #17914 is closed, because there was a PR.
The PR https://github.com/webcomponents/custom-elements/pull/112/files is merged.
Why do we still see this warning?
The warning occurs in the file webcomponents-ce.min.js:1:7969. I cant find a file with this name in the repo https://github.com/webcomponents/custom-elements or in the repo https://github.com/webcomponents/webcomponentsjs
Can it be that the file is outdated?
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Status | New | ⇒ | Discussion |
| Category | ⇒ | Code style |
How can we update thar file?
So this is partly my fault as I didn’t realized that there were 2 console.warns in the script: webcomponents/custom-elements#106
Ok, I was wrong, the latest file doesn not contain that console.log. Anyways I'll do a PR to get the latest polyfills and remove that warning
With this patch I neither see the warning in the console of the browser nor in the javascript tests. So it is fine.
But I wonder where the file /media/system/js/polyfills/webcomponents/webcomponents-ce.js comes from. Is it a special file for Joomla! ?
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-30 12:33:44 |
| Closed_By | ⇒ | astridx |
Yes, this file needs updating.