J4 Issue ?
Referenced as Duplicate of: # 28671
avatar mbabker
mbabker
21 Jan 2018

Meta issue tracking tasks for the Install from Web plugin (style and JavaScript related tasks are in this repo, markup related work goes to https://github.com/joomla-extensions/install-from-web-server):

  • Migrate the loading container to use Joomla.loadingLayer JavaScript (Complete in #23104)
  • jQuery Decoupling
    • Requests (all AJAX GET requests using JSONP)
    • Custom Events (ajaxStart and ajaxStop which honestly is just the loading layer logic) (Complete in #23104)
    • Animations
      • There is a smooth scroll to top for page navigation
      • When the "Install" button on free extensions is clicked on the single extension view, the main body area is hidden so the confirm box (#uploadform-web) is the only part of the tab visible
  • Change #web-loader-error element to use alert CE
  • Load language strings through Text::script() and use corresponding JavaScript
  • Re-implement the .fader element
  • Restore the link to the JED category in the breadcrumb element
  • Break dependency to global variables (can only apply to 4.0 layouts/script)
  • Bootstrap 5 review
avatar mbabker mbabker - open - 21 Jan 2018
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Jan 2018
avatar mbabker mbabker - change - 21 Jan 2018
The description was changed
avatar mbabker mbabker - edited - 21 Jan 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Jan 2018
Build staging 4.0-dev
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Jan 2018
Category JavaScript
avatar C-Lodder
C-Lodder - comment - 22 Jan 2018

Do you want me to handle the JS?

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Jan 2018
Status New Discussion
avatar brianteeman
brianteeman - comment - 22 Jan 2018

go for it!!

Migrating it to the core was about my limit ;)

avatar mbabker mbabker - change - 20 Feb 2018
The description was changed
avatar mbabker mbabker - edited - 20 Feb 2018
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar mbabker mbabker - change - 3 Jun 2018
The description was changed
avatar mbabker mbabker - edited - 3 Jun 2018
avatar mbabker mbabker - change - 3 Jun 2018
The description was changed
avatar mbabker mbabker - edited - 3 Jun 2018
avatar mbabker mbabker - change - 3 Jun 2018
The description was changed
avatar mbabker mbabker - edited - 3 Jun 2018
avatar mbabker mbabker - change - 3 Jun 2018
The description was changed
avatar mbabker mbabker - edited - 3 Jun 2018
avatar mbabker mbabker - change - 17 Nov 2018
The description was changed
avatar mbabker mbabker - edited - 17 Nov 2018
avatar mbabker mbabker - change - 17 Nov 2018
The description was changed
avatar mbabker mbabker - edited - 17 Nov 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Apr 2019
Title
[4.0][META] Install from Web Tasks
[4.0] [META] Install from Web Tasks
avatar joomla-cms-bot joomla-cms-bot - edited - 2 Apr 2019
avatar brianteeman
brianteeman - comment - 15 Jul 2019

Restore the link to the JED category in the breadcrumb element

Took me ages to find that link :)
Do we really need it?

avatar mbabker
mbabker - comment - 16 Jul 2019

Probably not, but I used the 3.x layouts as the design guide which has that link. So for consistency it should either exist for the 4.0 layouts or go away completely.

avatar jwaisner
jwaisner - comment - 19 Mar 2020

bumping for any updates that may be needed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19429.

avatar mbabker
mbabker - comment - 19 Mar 2020

Well considering nobody has touched the plugin code, I would say there is no need for any updates because nothing has been done to warrant an update.

avatar wilsonge
wilsonge - comment - 12 Apr 2020

So I don't see why any of the above would block install from web from functioning?

avatar wilsonge wilsonge - change - 12 Apr 2020
Labels Added: ?
avatar wilsonge wilsonge - labeled - 12 Apr 2020
avatar mbabker
mbabker - comment - 12 Apr 2020

It functions just fine last I checked (which admittedly was no time this year). The UI is broken mainly. In 3.x clicking the install button has a transition effect to show the user an info block and actually do the install or go to the developer's website. Because all the jQuery stuff (minus ajax) was commented out without immediately replacing the functionality right now clicking that button shows the info block at the bottom of the view without any clue to the user it's there.

avatar brianteeman
brianteeman - comment - 12 Apr 2020

image

avatar wilsonge
wilsonge - comment - 13 Apr 2020

But that install doesn’t work either and gives a JS error Joomla.submitButton5 is not defined (which I can’t find a reference to the in the repo here) and only in the plugin directory of the install-from-web repo

avatar mbabker
mbabker - comment - 13 Apr 2020

I’m pretty sure I renamed the function to something more clear and in the plugin JS class instead of the Joomla object when doing the ES6 rewrite.

avatar mbabker
mbabker - comment - 13 Apr 2020

59ca5aa#diff-8a5c0e9223fc9e812752777d2be474aaL299

For the life of me I can't work out how that was replaced.

avatar richard67
richard67 - comment - 7 May 2020

Install from web doesn't really work in J4 as of today (2020-05-07). See #28981 (comment) and comment below it.

  • The modal isn't a modal it seems, but still has buttons for a modal.
  • When using the install button of the "modal" for a J4 alpha compatible extension (akeeba backup), nothing happens, and the browser console shows: "Uncaught TypeError: Joomla.submitbutton5 is not a function at HTMLInputElement.onclick (index.php?option=com_installer&view=install:349)".
avatar richard67
richard67 - comment - 7 May 2020

Ah I see a few comments above, you know that already.

avatar C-Lodder
C-Lodder - comment - 8 May 2020
  • jQuery decoupling: fixed in #28981
avatar wilsonge wilsonge - change - 9 May 2020
The description was changed
avatar wilsonge wilsonge - edited - 9 May 2020
avatar HLeithner
HLeithner - comment - 25 Nov 2020

@C-Lodder can you help fixing the rest of the tasks?

avatar C-Lodder
C-Lodder - comment - 26 Nov 2020

alerts already moved to CE's here: #28992

Re-implement the .fader element

No idea what this is, but don't think it's required

Restore the link to the JED category in the breadcrumb element

Breadcrumb links already take you to the JED category within the web installer.

avatar wilsonge wilsonge - change - 28 Jan 2021
The description was changed
avatar wilsonge wilsonge - edited - 28 Jan 2021
avatar joomdonation
joomdonation - comment - 13 Mar 2021

Base on comments from @C-Lodder, I think all the tasks in this issue were completed. @richard67 Maybe you can take a look at it and confirm (or someone has experience with install from web can check and make sure it is working as expected). I just tried to use and see that it is working well.

avatar brianteeman
brianteeman - comment - 13 Mar 2021

None of this looks correct

image

avatar richard67
richard67 - comment - 13 Mar 2021

@brianteeman Could that come from #32422 ? If so, then the look of these fields is something on the big list to be cleaned up, i.e. not specific to the install from web.

Or is it maybe a BS 5 thing? Then it is covered by the last item "Bootstrap 5 review" in the check list in the description.

@joomdonation Unfortunately I'm not deep enough into the install from web to be the one who can sort it out.

avatar brianteeman
brianteeman - comment - 13 Mar 2021

BS5 i think

avatar joomdonation
joomdonation - comment - 13 Mar 2021

Would be great if someone with frontend skill could finish this BS5 task so that we can close this release blocker.

avatar richard67
richard67 - comment - 13 Mar 2021

Maybe @drmenzelit could have a look on it and check if it needs some adjustments to BS 5 in css or markup?

Or could there be js issues, too, related to BS 5 changes? In this case @dgrammatiko should have a look on it, too.

avatar rdeutz rdeutz - change - 24 Mar 2021
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2021-03-24 23:17:05
Closed_By rdeutz
Labels Added: ?
Removed: ?
avatar rdeutz rdeutz - close - 24 Mar 2021
avatar rdeutz
rdeutz - comment - 24 Mar 2021

Final bits are done in #32851, closing this

avatar rdeutz rdeutz - change - 24 Mar 2021
Labels Removed: ?
avatar rdeutz rdeutz - unlabeled - 24 Mar 2021

Add a Comment

Login with GitHub to post a comment