Meta issue tracking tasks for the Install from Web plugin (style and JavaScript related tasks are in this repo, markup related work goes to https://github.com/joomla-extensions/install-from-web-server):
Joomla.loadingLayer
JavaScript (Complete in #23104)ajaxStart
and ajaxStop
which honestly is just the loading layer logic) (Complete in #23104)#uploadform-web
) is the only part of the tab visible#web-loader-error
element to use alert CEText::script()
and use corresponding JavaScript.fader
elementLabels |
Added:
?
|
Build | staging | ⇒ | 4.0-dev |
Category | ⇒ | JavaScript |
Status | New | ⇒ | Discussion |
go for it!!
Migrating it to the core was about my limit ;)
Labels |
Added:
J4 Issue
|
Title |
|
Restore the link to the JED category in the breadcrumb element
Took me ages to find that link :)
Do we really need it?
Probably not, but I used the 3.x layouts as the design guide which has that link. So for consistency it should either exist for the 4.0 layouts or go away completely.
bumping for any updates that may be needed.
Well considering nobody has touched the plugin code, I would say there is no need for any updates because nothing has been done to warrant an update.
So I don't see why any of the above would block install from web from functioning?
Labels |
Added:
?
|
It functions just fine last I checked (which admittedly was no time this year). The UI is broken mainly. In 3.x clicking the install button has a transition effect to show the user an info block and actually do the install or go to the developer's website. Because all the jQuery stuff (minus ajax) was commented out without immediately replacing the functionality right now clicking that button shows the info block at the bottom of the view without any clue to the user it's there.
But that install doesn’t work either and gives a JS error Joomla.submitButton5 is not defined (which I can’t find a reference to the in the repo here) and only in the plugin directory of the install-from-web repo
I’m pretty sure I renamed the function to something more clear and in the plugin JS class instead of the Joomla object when doing the ES6 rewrite.
59ca5aa#diff-8a5c0e9223fc9e812752777d2be474aaL299
For the life of me I can't work out how that was replaced.
Install from web doesn't really work in J4 as of today (2020-05-07). See #28981 (comment) and comment below it.
Ah I see a few comments above, you know that already.
alerts already moved to CE's here: #28992
Re-implement the .fader element
No idea what this is, but don't think it's required
Restore the link to the JED category in the breadcrumb element
Breadcrumb links already take you to the JED category within the web installer.
Base on comments from @C-Lodder, I think all the tasks in this issue were completed. @richard67 Maybe you can take a look at it and confirm (or someone has experience with install from web can check and make sure it is working as expected). I just tried to use and see that it is working well.
@brianteeman Could that come from #32422 ? If so, then the look of these fields is something on the big list to be cleaned up, i.e. not specific to the install from web.
Or is it maybe a BS 5 thing? Then it is covered by the last item "Bootstrap 5 review" in the check list in the description.
@joomdonation Unfortunately I'm not deep enough into the install from web to be the one who can sort it out.
BS5 i think
Would be great if someone with frontend skill could finish this BS5 task so that we can close this release blocker.
Maybe @drmenzelit could have a look on it and check if it needs some adjustments to BS 5 in css or markup?
Or could there be js issues, too, related to BS 5 changes? In this case @dgrammatiko should have a look on it, too.
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-24 23:17:05 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
Removed: ? |
Labels |
Removed:
?
|
Do you want me to handle the JS?