? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
21 Jan 2018

Summary of Changes

This will restructure the CSS for the install from web plugin's media so that it is compiled through a SCSS file. This is going to have a couple of benefits:

  • Able to use the Bootstrap mixin for the badge style variants (the server markup should be updated to go back to using these custom variants versus the generic success/warning/whatnot)
  • Able to use the Bootstrap gradient mixin
  • Gets the same post processing as the templates (i.e. browser support)

Since I built the layouts for 4.0 support only using the Bootstrap 4 structures and not really implementing anything custom, most of the style rules for the 3.x layouts are removed and at this point the only style rules left are things actively in use or things that need to be re-implemented (i.e. the .fader which creates the gradient effect at the bottom of cards so there isn't a hard break where the text cuts off).

Testing Instructions

With PR applied, validate the IFW tab renders the same as before.

avatar mbabker mbabker - open - 21 Jan 2018
avatar mbabker mbabker - change - 21 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2018
Category JavaScript Repository
avatar mbabker mbabker - change - 21 Jan 2018
Labels Added: ?
avatar brianteeman brianteeman - test_item - 22 Jan 2018 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Jan 2018

I have tested this item successfully on 89e6964


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19428.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jan 2018

I have tested this item successfully on 89e6964


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19428.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 Jan 2018 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Jan 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Jan 2018

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 28 Jan 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-28 19:59:48
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 28 Jan 2018
avatar mbabker mbabker - merge - 28 Jan 2018

Add a Comment

Login with GitHub to post a comment