[#19428] - [4.0] Make the IFW styling compile with SCSS, nuke most unused rules
- Fixed in Code Base
- 28 Jan 2018
- Medium
- Build: 4.0-dev
- # 19428
- Diff
- mbabker:ifw-scss
User tests: Successful: Unsuccessful:
Summary of Changes
This will restructure the CSS for the install from web plugin's media so that it is compiled through a SCSS file. This is going to have a couple of benefits:
- Able to use the Bootstrap mixin for the badge style variants (the server markup should be updated to go back to using these custom variants versus the generic success/warning/whatnot)
- Able to use the Bootstrap gradient mixin
- Gets the same post processing as the templates (i.e. browser support)
Since I built the layouts for 4.0 support only using the Bootstrap 4 structures and not really implementing anything custom, most of the style rules for the 3.x layouts are removed and at this point the only style rules left are things actively in use or things that need to be re-implemented (i.e. the .fader which creates the gradient effect at the bottom of cards so there isn't a hard break where the text cuts off).
Testing Instructions
With PR applied, validate the IFW tab renders the same as before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19428.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-28 19:59:48 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 89e6964
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19428.