? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
7 Jan 2018

Currently, radios with the class "btn-group" are broken in J4 as you can't change the value at all. The radio is just unresponsive to your clicking.

Summary of Changes

  • Removes the special JS done in the Cassiopeia and Atum templates. Since Bootstrap is loaded anyway and it offers the same functionality, we can use just that one for now (until it gets eventually converted to a CE).
  • Adjusts the JLayout for the radio formfield so it works with the Bootstrap code.
    Thanks to @C-Lodder for that work!

Testing Instructions

To test, you can add the following code to the config.xml of any extension. Eg to /administrator/components/com_content/config.xml. Just put it right after the <config> tag.

	<fieldset
		name="test"
		label="Test"
	>
		<field
			name="plain"
			type="radio"
			class=""
			default="1"
		>
			<option value="1">Foo</option>
			<option value="0">Bar</option>
		</field>

		<field
			name="btn-group"
			type="radio"
			class="btn-group"
			default="1"
		>
			<option value="1">Foo</option>
			<option value="0">Bar</option>
		</field>

		<field
			name="btn-group-yesno"
			type="radio"
			class="btn-group btn-group-yesno"
			default="1"
		>
			<option value="1">JYES</option>
			<option value="0">JNO</option>
		</field>

		<field
			name="btn-group-yesno reordered"
			type="radio"
			class="btn-group btn-group-yesno"
			default="1"
		>
			<option value="0">JNO</option>
			<option value="1">JYES</option>
		</field>

		<field
			name="switcher"
			type="radio"
			class="switcher"
			default="1"
		>
			<option value="0">JNO</option>
			<option value="1">JYES</option>
		</field>
	</fieldset>

Now go to the settings of that component. You will have a new tab with 5 parameters.
Check if the radios work.
Make also sure the plain radios and the switcher work as well.

Expected result

image
All radios work
We even get some styling as expected, but main point is they work ?

Actual result

image
The marked radios are not working (and styling doesn't exist).

Documentation Changes Required

None

avatar Bakual Bakual - open - 7 Jan 2018
avatar Bakual Bakual - change - 7 Jan 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Jan 2018
Category Administration Templates (admin) JavaScript Layout Front End Templates (site)
avatar Bakual Bakual - change - 7 Jan 2018
Labels Added: ?
avatar dgt41
dgt41 - comment - 7 Jan 2018

@Bakual can you also incorporate the changes in #19296
So we don’t have a bunch of prs doing a little bit of something over the same files?

avatar Bakual
Bakual - comment - 7 Jan 2018

@dgt41 Haven't seen that PR before but I like the basic idea to split the layouts. However I need to have a look at it first. Will comment on the other PR with my first thoughts ?

avatar Quy Quy - change - 7 Jan 2018
Title
Fix radio btn group
[4.0] Fix radio btn group
avatar joomla-cms-bot joomla-cms-bot - edited - 7 Jan 2018
avatar infograf768
infograf768 - comment - 8 Jan 2018

Except for the density of the Grey colour (too light) when class switcher is used and No is chosen, this works fine here.

avatar Bakual
Bakual - comment - 8 Jan 2018

I try to not comment on that switcher thing ?
@infograf768 Can you mark it as successful test then? The switcher colors aren't part of this PR, I just included the switcher so it is verfified it still works.

avatar infograf768 infograf768 - test_item - 8 Jan 2018 - Tested successfully
avatar infograf768
infograf768 - comment - 8 Jan 2018

I have tested this item successfully on e5398e4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19326.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 8 Jan 2018 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Jan 2018

I have tested this item successfully on e5398e4

Hint: Switch of

  • btn-group
  • btn-group-yesno
  • btn-group-yesno reordered

works different to Switch "switcher" cause User has to click on "Foo" or "Bar"; at "switcher" User click on green Field to switch from "Yes" to "No" and vice versa.

But i guess this is out of Scope of PR so a successfully test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19326.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Jan 2018
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Jan 2018

Ready to Commit after two successful tests.

avatar wilsonge wilsonge - close - 1 Feb 2018
avatar wilsonge wilsonge - merge - 1 Feb 2018
avatar wilsonge wilsonge - change - 1 Feb 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-02-01 21:35:31
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 1 Feb 2018

Thanks!

avatar wilsonge
wilsonge - comment - 1 Feb 2018

Tests fixed with 550ef7b

avatar HB12broker
HB12broker - comment - 17 Feb 2019

Every successful business men and women keeps the growth of their capital through investment, to also be the most riches person in the world investment must be your first priority. Today, you can be an investor with the help of a manager that knows how to control capitals in trading without lost and apply for loan. Trade with Optionfield company today and have your agent to manage your account, for enquiry email on: houngbrowne@gmail.com


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19326.

Add a Comment

Login with GitHub to post a comment