User tests: Successful: Unsuccessful:
Currently, radios with the class "btn-group" are broken in J4 as you can't change the value at all. The radio is just unresponsive to your clicking.
To test, you can add the following code to the config.xml of any extension. Eg to /administrator/components/com_content/config.xml. Just put it right after the <config>
tag.
<fieldset
name="test"
label="Test"
>
<field
name="plain"
type="radio"
class=""
default="1"
>
<option value="1">Foo</option>
<option value="0">Bar</option>
</field>
<field
name="btn-group"
type="radio"
class="btn-group"
default="1"
>
<option value="1">Foo</option>
<option value="0">Bar</option>
</field>
<field
name="btn-group-yesno"
type="radio"
class="btn-group btn-group-yesno"
default="1"
>
<option value="1">JYES</option>
<option value="0">JNO</option>
</field>
<field
name="btn-group-yesno reordered"
type="radio"
class="btn-group btn-group-yesno"
default="1"
>
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
<field
name="switcher"
type="radio"
class="switcher"
default="1"
>
<option value="0">JNO</option>
<option value="1">JYES</option>
</field>
</fieldset>
Now go to the settings of that component. You will have a new tab with 5 parameters.
Check if the radios work.
Make also sure the plain radios and the switcher work as well.
All radios work
We even get some styling as expected, but main point is they work
The marked radios are not working (and styling doesn't exist).
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) JavaScript Layout Front End Templates (site) |
Labels |
Added:
?
|
Title |
|
Except for the density of the Grey colour (too light) when class switcher is used and No is chosen, this works fine here.
I try to not comment on that switcher thing
@infograf768 Can you mark it as successful test then? The switcher colors aren't part of this PR, I just included the switcher so it is verfified it still works.
I have tested this item
I have tested this item
Hint: Switch of
works different to Switch "switcher" cause User has to click on "Foo" or "Bar"; at "switcher" User click on green Field to switch from "Yes" to "No" and vice versa.
But i guess this is out of Scope of PR so a successfully test.
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-01 21:35:31 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
Every successful business men and women keeps the growth of their capital through investment, to also be the most riches person in the world investment must be your first priority. Today, you can be an investor with the help of a manager that knows how to control capitals in trading without lost and apply for loan. Trade with Optionfield company today and have your agent to manage your account, for enquiry email on: houngbrowne@gmail.com
@Bakual can you also incorporate the changes in #19296
So we don’t have a bunch of prs doing a little bit of something over the same files?