[#19325] - [4.0] Store module namespace on installation
- Fixed in Code Base
- 22 Jan 2018
- Medium
- Build: 4.0-dev
- # 19325
- Diff
- joomdonation:patch-18
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR did two things:
-
Store namespace for module when modules are installed/updated
-
Update xml files to have correct namespace tag for namespaced modules
This PR is created so that @wilsonge can finish his PR #18703
Testing Instructions
Can be merged by code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Libraries Front End |
our current code doesn't store namespace of modules during install
The modules you have updated are not "intalled" by the installer so i dont see how updating the xml of these modules will have any effect
When someone wants to develop a new module which supports namespace, he can looks at the XML file of one of core modules to know how to set namespace for the module (so that the module classes will be uploadable). We do that for our core components, too
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19325.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-22 21:44:08 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
i am a bit confused as the changes in the adapter are only for installed modules and none of these modules are installed that way