[#19324] - [4.0] Plugins using more namespaced classes Part 3 (Final)
- Fixed in Code Base
- 18 Jan 2018
- Medium
- Build: 4.0-dev
- # 19324
- Diff
- Anu1601CS:Plugins-Final
User tests: Successful: Unsuccessful:
Summary of Changes
Switch to the namespaced classes
Testing Instructions
Simple code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Everything seems to look ok from my end
Almost perfect. Just small things left as I commented. Also, look like you forgot to work on PlgInstallerFolderInstaller (plugins/installer/folderinstaller/folderinstaller.php), please work on that only remaining plugin as well
| Labels |
Added:
?
|
||
@joomdonation done!
I have already worked on plugins/installer/folderinstaller/folderinstaller.php but file is included in part2.
Next time I try to optimize these things.
Thanks :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19324.
You didn't, it was spam.
It's on my list. Just had a lot going on the last few weeks.
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19324.
| Status | Pending | ⇒ | Ready to Commit |
RTC
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-18 13:45:09 |
| Closed_By | ⇒ | wilsonge |
Awesome work! Thanks so much for this series :)
@C-Lodder please review changes.