[#19323] - [4.0] Plugins using more namespaced classes Part 2
- Fixed in Code Base
- 18 Jan 2018
- Medium
- Build: 4.0-dev
- # 19323
- Diff
- Anu1601CS:plugins
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Switch to the namespaced classes
Testing Instructions
Simple code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Everything here seems to look ok
There are still some small issues as I commented above. Please correct it and we should be fine. Also, I don't know if the change to filesystem plugin should be made here or on media manager repo
@joomdonation yeah, I am removing changes to filesystem because this file is a part of media manager and they have a separate repo. What do you think?
Thanks
I am unsure. Maybe keep the change for now as I guess the change here is also synchronized to media manager repo, too. For now, please make the small changes which I commented and you should be done with this PR.
Ok
@joomdonation done!
| Labels |
Added:
?
|
||
Please review changes
I have tested this item
Great work, thanks @Anu1601CS
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19323.
@joomdonation thanks, I contribute to joomla as I can.
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19323.
Quy
- | Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-18 13:44:38 |
| Closed_By | ⇒ | wilsonge |
@C-Lodder please review changes