Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#19269] - [4.0] Rewrite sampledata-process.js

? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
3 Jan 2018

Pull Request for Issue #19263

Summary of Changes

  • Rewrite in vanilla JS
  • Use Custom Element alerts instead of BS
  • Progress bar now increments as per the step it's on.
  • Create minified file

Testing Instructions

If you want to test, you'll need to ensure you have no sample data installed already. So install a fresh copy of Joomla and attempt to install sample data.

If you do have sample data already installed, the process should stop on step 1 and display an error alert.

avatar C-Lodder C-Lodder - open - 3 Jan 2018
avatar C-Lodder C-Lodder - change - 3 Jan 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jan 2018
Category ⇒ Modules Administration JavaScript
avatar C-Lodder C-Lodder - change - 3 Jan 2018
The description was changed
avatar C-Lodder C-Lodder - edited - 3 Jan 2018
avatar Anu1601CS Anu1601CS - test_item - 3 Jan 2018 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 3 Jan 2018

I have tested this item ✅ successfully on 2260268

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19269.

avatar brianteeman
brianteeman - comment - 6 Jan 2018

Maybe its just me but it seems wrong to have a class on a list called list-unstyled

Sorry realised that its an actual class in bootstrap - crazy

f7f0fdd 6 Jan 2018 avatar C-Lodder fa
avatar C-Lodder C-Lodder - change - 6 Jan 2018
Labels Added: ?
avatar C-Lodder C-Lodder - change - 2 Feb 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-02 10:44:34
Closed_By ⇒ C-Lodder
avatar C-Lodder C-Lodder - close - 2 Feb 2018
avatar C-Lodder C-Lodder - change - 8 Feb 2018
Status Closed ⇒ New
Closed_Date 2018-02-02 10:44:34 ⇒
Closed_By C-Lodder ⇒
avatar C-Lodder C-Lodder - change - 8 Feb 2018
Status New ⇒ Pending
avatar C-Lodder C-Lodder - reopen - 8 Feb 2018
avatar laoneo
laoneo - comment - 8 Feb 2018

Let us know when we can test.

avatar dgt41
dgt41 - comment - 8 Feb 2018

@C-Lodder couple of things that you need to do here:

  • change the ajax method from GET to POST
  • revert the data part of the ajax method
  • change the $app->input to $app->input->json in the php, components/com_ajax/ajax.php:
// Check for valid format
if (!$format)
{
	// JInput JSON object
	$input = $input = $app->input->json;

	// Requested format passed via URL
	$format = strtolower($input->getWord('format'));

	if (!$format) {
		$results = new InvalidArgumentException(JText::_('COM_AJAX_SPECIFY_FORMAT'), 404);
	}
}
avatar C-Lodder
C-Lodder - comment - 10 Feb 2018

@dgt41 - Inline script removed. Didn't you say com_ajax didn't support json?

avatar dgt41
dgt41 - comment - 10 Feb 2018

@C-Lodder I haven't actually tested the snippet above, so it might or might not work. Anyways this is pretty fine to be merged as is (if you don't have the time to dig into switching to json post)

avatar C-Lodder
C-Lodder - comment - 10 Feb 2018

@laoneo @Anu1601CS ready to test

avatar C-Lodder
C-Lodder - comment - 22 Feb 2018

Closing in favour of: joomla-projects/joomla-es6#58

avatar C-Lodder C-Lodder - change - 22 Feb 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-22 16:19:06
Closed_By ⇒ C-Lodder
avatar C-Lodder C-Lodder - close - 22 Feb 2018

Add a Comment

Login with GitHub to post a comment