Joomla! Issue Tracker | Joomla! CMS #19268 - Fix parser error in plugin languagefilter on php5

Fixed in Code Base
3 Jan 2018
Medium
Build: staging
# 19268
Diff
csthomas:fix_T_PAAMAYIM_NEKUDOTAYIM

Pending

User tests: Successful: Unsuccessful:

csthomas
3 Jan 2018

Pull Request for Issue #19267 .

Summary of Changes

Add a workaround for php5

Testing Instructions

Test Multilingual website on php5 or code review.

Expected result

No error.

Actual result

Parse error: syntax error, unexpected '::' (T_PAAMAYIM_NEKUDOTAYIM) in plugins\system\languagefilter\languagefilter.php on line 630

Documentation Changes Required

fc86a1c 3 Jan 2018

Fix parser error in plugin languagefilter on php5

csthomas - open - 3 Jan 2018

csthomas - change - 3 Jan 2018

Status

New

⇒

Pending

joomla-cms-bot - change - 3 Jan 2018

Category

⇒

Front End Plugins

csthomas - change - 3 Jan 2018

The description was changed

csthomas - edited - 3 Jan 2018

infograf768 - comment - 3 Jan 2018

unhappily, can’test here with php5

csthomas - comment - 3 Jan 2018

@jsubri Can you test it. It is only a few lines of changes. You can do it manual and test.

jsubri - comment - 3 Jan 2018

Fix do not trigger the T_PAAMAYIM_NEKUDOTAYIM anymore on my php 5.6.26 however PR #19099 breaks (B/C) URLs like /index.php/fr/component/content/article/alias123?catid=13 that were working fine on 3.8.3 with modern routing.

edited: better English
Edit2: typo due to Cut&Past, my worries are with 19099

jsubri - comment - 3 Jan 2018

Successful same as above with php 5.4.24, but a bit reluctant to add the success in Jissues as #19099 seems to trigger B/C on some URL

joomdonation - comment - 3 Jan 2018

@csthomas If you are unsure about B/C change, I think it is better to revert the #19099. It changes existing behavior, so it might break third party extensions. We should stay on safe side.

ea287e9 3 Jan 2018