[#19237] - Clean up ContentViewCategory
- Closed
- 15 Jan 2018
- Medium
- Build: staging
- # 19237
- Diff
- joomdonation:patch-13
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR makes some clean up to ContentViewCategory classes:
-
Use namespace classes instead of it's alias
-
Move $dispatcher = JEventDispatcher::getInstance(); out of the loop, so we get a bit performance improvement
-
Remove code to set view layout as it is set on parent class code already https://github.com/joomla/joomla-cms/blob/staging/libraries/src/MVC/View/CategoryView.php#L212-L223
-
Remove some un-used variables (like $id, $pathway), reuse-existing variable (no need for $menu = $menu->getActive() when we have $active variable keep active menu item before)
Testing Instructions
Code review should be enough. For human testing, please create a menu item to display articles from a category (Category Blog layout menu option for example), check and make sure articles still being displayed like before
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Labels |
Added:
?
|
||
| Category | Front End com_content | ⇒ | Repository Administration com_associations com_categories com_contact com_content com_fields com_finder com_installer com_redirect Language & Strings Modules Templates (admin) Front End |
Ouch
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-15 15:43:22 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 02f1b74
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19237.