? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
30 Dec 2017

Pull Request for Issue #18912 (comment) .

Summary of Changes

  • Normalise the method name for both PHP and JS world!
  • Add appropriate deprecation
  • Proxy Joomla.JText.* to Joomla.Text.*

Testing Instructions

Apply PR
Got to Admin -> Global configuration
Open the browser's console
Copy paste:

  • Joomla.JText._('ERROR') press enter you should see "Error"
  • Joomla.Text._('ERROR') press enter you should see "Error"
  • Joomla.JText.strings press enter you should see an object with all the available strings
  • Joomla.Text.strings press enter you should see the same object with all the available strings as before
  • Joomla.Text.load({TEST: "test"}) and press enter then Joomla.Text.strings and check that TEST is there
  • Joomla.Text.load({TESTA: "testa"}) and press enter then Joomla.Text.strings and check that TESTA is there

Expected result

Everything works as usual

Actual result

screen shot 2017-12-31 at 00 35 46

Documentation Changes Required

There are a bunch of console warnings added to help 3RD PD move forward. There will be a section in the documentation that will cover all the changes for J4.0

@mbabker up to you...

avatar dgt41 dgt41 - open - 30 Dec 2017
avatar dgt41 dgt41 - change - 30 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2017
Category JavaScript
avatar dgt41 dgt41 - change - 30 Dec 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 7 Jan 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-07 17:01:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 7 Jan 2018
avatar wilsonge wilsonge - merge - 7 Jan 2018

Add a Comment

Login with GitHub to post a comment