User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Currently, we have code to set layout for category view base on active menu item and layout setting from the category itself. The logic is:
If the current active menu item is a direct menu link to the category being displayed, then use the layout from menu item
If the above condition is wrong, then the layout set up for the category will be used
This PR keeps that same logic, but improves the code a bit to have more accurate + easier to read:
It compares component property of active menu item with the component of the view (original code ignore it)
Compare view and id directly instead of using strpos like in the original code
Code review can be considered as successful test
For human testing:
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-02-13 00:05:00 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
I have tested this item✅ successfully on 04a414b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19238.