[#19232] - [4.0] Switcher is now a Custom Element
- Fixed in Code Base
- 3 Jan 2018
- Medium
- Build: 4.0-dev
- # 19232
- Diff
- C-Lodder:switcher-ce
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR migrates the Switcher field over to a dedicated custom element which has been approved by the a11y team.
Testing Instructions
Go to the Global Configuration (or any other page that uses a switcher) and ensure it works the same as it did before.
Note, please ignore the colours. We still need to publish an update to NPM and properly pull the elements using the new package manager. Once done and we start working on the new template, we'll work the the necessary SCSS changes.
Hope @brianteeman likes the removal or the border radius :)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Layout JavaScript Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Why is there always a "throbber" outline on the No value?
Ignore that comment - it was a cache issue
Nope it was a brian issue and is a problem - you can probably only see it when you tab from one switcher to another
(i will post a video soon - there are a few issues)
Brian, I purposely added the pulsating focus state, not an issue. Inspired by Google
But why is it always on the NO value
ok - i get it now. its not on the no value but its on the switch
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Category | Administration Templates (admin) Layout JavaScript Front End Templates (site) | ⇒ | JavaScript Repository Administration Templates (admin) Layout Front End Templates (site) |
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-03 00:05:15 |
| Closed_By | ⇒ | wilsonge |
Hold on tight
I have tested this item✅ successfully on e455b9d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19232.