PR-4.0-dev

Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
30 Dec 2017

Part of the effort to convert all fields to Custom Elements

Summary of Changes

  • One script to rule them all
  • Ability to set multiple validation handlers (per field)
  • Remove Bootstrap/Font Awesome and other unneeded dependencies so the field can play nicely in every known css framework
  • Some code improvements

@ciar4n can you take care of the css @todos ?

Testing Instructions

For easy testing you can apply this patch and check the admin login:
screen shot 2017-12-30 at 17 47 02
screen shot 2017-12-30 at 17 47 12
screen shot 2017-12-30 at 17 47 20
screen shot 2017-12-30 at 17 47 28

Issues

  • The show/hide button doesn't look like a button
  • Still Bootstrap specific
  • Still Font awesome specific
  • Needs A11Y audit
  • Needs final approval form the design team

But the functionality should be spot on!

Expected result

Actual result

Documentation Changes Required

avatar dgt41 dgt41 - open - 30 Dec 2017
avatar dgt41 dgt41 - change - 30 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2017
Category JavaScript Repository Layout
avatar dgt41 dgt41 - change - 30 Dec 2017
Labels Added: PR-4.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2017
Category JavaScript Repository Layout Modules Administration JavaScript Repository Layout
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2017
Category JavaScript Repository Layout Modules Administration Administration Language & Strings Modules JavaScript Repository Layout
avatar dgt41 dgt41 - change - 30 Dec 2017
Labels Added: Language Change
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2017
Category JavaScript Repository Layout Modules Administration Language & Strings Modules Administration JavaScript Repository Layout
avatar dgt41 dgt41 - change - 30 Dec 2017
The description was changed
avatar dgt41 dgt41 - edited - 30 Dec 2017
avatar dgt41 dgt41 - change - 30 Dec 2017
Labels Removed: Language Change
avatar dgt41
dgt41 - comment - 23 Mar 2018

The Todo list is still relevant:

  • Still Bootstrap specific
  • Still Font awesome specific
  • Needs A11Y audit
  • Needs final approval form the design team
avatar dgt41
dgt41 - comment - 24 Mar 2018

BTW the show/hide button is rendered properly now:
screen shot 2018-03-23 at 19 35 18
screen shot 2018-03-23 at 19 38 10

avatar brianteeman
brianteeman - comment - 22 Jul 2018

@dgrammatiko can you update this to resolve the conflicts so that this can be tested please

avatar dgrammatiko
dgrammatiko - comment - 22 Jul 2018

sure

PS there are still a few todo that needs to be done at some point (preferably before merging)
#19231 (comment)

0c3be25 22 Jul 2018 avatar dgrammatiko init
06c57df 22 Jul 2018 avatar dgrammatiko more
1ae5c06 22 Jul 2018 avatar dgrammatiko sync
0959c93 22 Jul 2018 avatar dgrammatiko upd
avatar brianteeman
brianteeman - comment - 22 Jul 2018

Tested on the new user page in the admin

  1. This page has two password fields - which produces two copies of the css to be inserted. Surely thats not correct

chrome_2018-07-22_20-16-32

  1. There appears to be a missing close > which is stopping it working

chrome_2018-07-22_20-17-59

avatar dgrammatiko
dgrammatiko - comment - 22 Jul 2018

Ok I've messed up the sync, will fix it

avatar brianteeman
brianteeman - comment - 8 Aug 2018

As a temp measure until you resolve the outstanding issues and this can be accepted I did a quick pr to fix the button styling on the current code #21462

avatar dgrammatiko dgrammatiko - change - 29 Aug 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-08-29 10:23:16
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 29 Aug 2018

Add a Comment

Login with GitHub to post a comment