Feeling Lucky
?
[#19228] - [4.0] Html5 does not have a closing tag on br
- Fixed in Code Base
- 30 Dec 2017
- Medium
- Build: 4.0-dev
- # 19228
- Diff
- brianteeman:br_again_4
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Sure I did this before but this PR removes the use of a closing slash on a br tag as this is not correct for html5
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Templates (admin) JavaScript Front End Templates (site) |
Anu1601CS
- comment
- 30 Dec 2017
If We are using xhtml systems that generate HTML based on XML generators. XHTML Elements Must Always Be Closed.
So, use of closing tag on br is more fine to use because it support both html5 and xhtml
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19228.
brianteeman
- comment
- 30 Dec 2017
Joomla 4 is html5 not XHTML
Anu1601CS
- comment
- 30 Dec 2017
Ok done!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19228.
Anu1601CS
- comment
- 30 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19228.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 30 Dec 2017
Ready to Commit after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-30 16:50:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 30 Dec 2017
Thanks
I have tested this item✅ successfully on b0f30f9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19228.