? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
30 Dec 2017

Pull Request for Issue #17817

Summary of Changes

This PR adds a max width to the .custom-select class, and also fixes the grid issue on the Global Config

Testing Instructions

  1. Select boxes should not overlap the parent element and should be the same width as input fields
  2. The global config settings UI should be the same as before. Site Settings on the left and SEO Settings on the right
avatar C-Lodder C-Lodder - open - 30 Dec 2017
avatar C-Lodder C-Lodder - change - 30 Dec 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Dec 2017
Category Administration Templates (admin) Front End Templates (site)
avatar brianteeman
brianteeman - comment - 30 Dec 2017

screen shot 2017-12-30 at 13 50 29

As you can see in the screenshot the width is now corrected but there is no border on the right or bottom only on the top on left


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19229.

avatar C-Lodder
C-Lodder - comment - 30 Dec 2017

Fine for me on FF.

Can you check the Bootstrap demo site and use the inspector to add a long option?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Dec 2017

I have tested this item successfully on c6010de

bildschirmfoto 2017-12-30 um 15 15 30

System information

4.0-dev
Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)

MAMP 4.2

  • Apache-Server
  • PHP 7.0.22
  • MySQLi 5.6.35

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19229.
avatar brianteeman
brianteeman - comment - 30 Dec 2017

Works fine on the getbootstrap site
Its not just the dropdowns with a long value it is all of them on chrome

avatar C-Lodder C-Lodder - change - 2 Jan 2018
Labels Added: ?
avatar ciar4n
ciar4n - comment - 2 Jan 2018

Seems to be fine on Windows Chrome (63.0)...

image

avatar C-Lodder C-Lodder - change - 2 Jan 2018
Title
SCSS Tweaks
[4.0] SCSS Tweaks
avatar C-Lodder C-Lodder - edited - 2 Jan 2018
avatar wilsonge
wilsonge - comment - 2 Jan 2018

I'm also good in Chrome. I'm going to merge this for now so Charlie doesn't get years of conflicts. Brian if you're still getting this could you sit down and screenshare with charlie so he can debug because it doesn't seem like any of the rest of us can reproduce your issue :/

avatar wilsonge wilsonge - change - 2 Jan 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-02 23:38:43
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Jan 2018
avatar wilsonge wilsonge - merge - 2 Jan 2018
avatar brianteeman
brianteeman - comment - 2 Jan 2018

@wilsonge was that chrome on mac or windows? My test was windows

avatar wilsonge
wilsonge - comment - 3 Jan 2018

Mine was a mac. Ciaran was windows, so I think both bases got covered

Add a Comment

Login with GitHub to post a comment