Feeling Lucky
?
[#19225] - [4.0] Button type button
- Fixed in Code Base
- 30 Dec 2017
- Medium
- Build: 4.0-dev
- # 19225
- Diff
- brianteeman:button
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
HTML5 default is for a button to be a submit - here it needs to be a button
To test on the front end click on the Versions button when editing an article
Before this PR the modal does not open
After this PR the modal will open
The error in the modal is a different issue
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
Anu1601CS
- comment
- 30 Dec 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19225.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 30 Dec 2017
Ready to Commit after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-30 16:46:27 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 30 Dec 2017
Thanks :)
brianteeman
- comment
- 30 Dec 2017
Thanks
I have tested this item✅ successfully on b90fd4a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19225.