[#19224] - [4.0] Modal grey background not full width
- Closed
- 31 Dec 2017
- Medium
- Build: 4.0-dev
- # 19224
Steps to reproduce the issue
4.0-dev install
login frontend as super admin
click Template Settings
Click Select on the logo media selector
Expected result
Full width grey background under modal
Actual result
grey background clipped at edges
(Note Im on HALF a 27" screen)
System information (as much as possible)
Additional comments
| Labels |
Added:
?
|
||
| Build | staging | ⇒ | 4.0-dev |
| Category | ⇒ | Administration Front End Templates (site) |
| Status | New | ⇒ | Confirmed |
@ciar4n this is causing the issue: https://github.com/joomla/joomla-cms/blob/4.0-dev/templates/cassiopeia/scss/blocks/_layout.scss#L11
As far as I can tell, all child element of the <body> use the .container-* class, so seeing as you added:
can we remove max-width: 1080px + ($cassiopeia-grid-gutter * 4);?
@C-Lodder if we remove max-width: 1080px + ($cassiopeia-grid-gutter * 4); is this issue solve ??
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19224.
@Anu1601CS - yes this does resolve the issue, however Ciaran wrote the css-grid, so he may have added this for a reason. Don't want to remove it until I get confirmation from him. If it needs to stay, then we can replace this:
.site {
background-color: #fafafa;
> div {... }
}
with:
.site {
background-color: #fafafa;
> div:not(.modal-backdrop) {... }
}
although I'm not a fan of that approach
@C-Lodder ok thanks
What about at this line
joomla-cms/templates/cassiopeia/css/template.css
Line 8814 in 125821f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19224.
That's what the SCSS compiles to. We don't edit CSS files, we edit the SCSS files then compile it
ok thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19224.
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-31 12:40:22 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/19224
Issue confirmed:
System information
4.0.0-dev
Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2